feat(analytics): report account signups to X Ads by waleedlatif1 · Pull Request #9212 · simstudioai/sim

waleedlatif1 · 2026-10-18T23:51:49Z

Summary

Reports completed account signups to the X Ads pixel as the "Sim Account Sign Up" event (tw-q5xbl-rhis8), so X Ads campaigns can optimize for signups.
Loads the consent-gated X pixel on the signup flow (previously landing pages only), same marketing consent gating.
Covers email signups and new social (Google, GitHub) signups; returning logins do not fire.
Google Ads conversion labels unchanged; a sign_up label will follow separately.

Type of Change

Bug fix / tracking fix

Testing

See agent notes below and CI.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

https://claude.ai/code/session_01YXGD8yrPh6YUMvcLKFPQMs

waleedlatif1 · 2026-10-18T23:51:52Z

@cubic review

waleedlatif1 · 2026-10-18T23:51:52Z

@greptile

vercel · 2026-10-18T23:51:54Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 19, 2026 12:03am UTC

cubic-dev-ai · 2026-10-18T23:51:57Z

@cubic review

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 11 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

greptile-apps · 2026-10-18T23:58:25Z

Confidence Score: 4/5

[Medium impact] Adds signup conversion tracking to X Ads and other vendors.

The previous testing and component requirements still need to be met before merging; no new issue was found.

Findings

Tracking can block signup ▶
Tests skip the signup journey ▶
Required props interfaces are missing ▶

Summary

Reports completed signups to X Ads when marketing consent allows it.

New account signups report consent-approved conversion events.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Email signup] --> B{Verification required?}
  B -->|No| C[Report allowed conversions]
  C --> G[Requested page]
  B -->|Yes| D[Save marker and requested page]
  D --> E[Verify email code]
  E --> F[Signup completion page]
  H[New social signup] --> F
  F --> I[Check session, consent, and marker]
  I --> J[Report once if eligible]
  J --> G
  K[Returning social login] --> G

_{Reviews (2) · Last reviewed commit: "Pi Babysit: address PR #9212 feedback" · Reviewed by Greptile}

greptile-apps · 2026-10-18T23:58:28Z

+    const finishSignUp = async () => {
+      if (session?.user && isSocialSignInProvider(provider)) {
+        await trackSocialSignUpConversions({
+          marker,
+          provider,
+          userId: session.user.id,
+          measurement: consentRequired && measurement,
+          marketing: consentRequired && marketing,
+        })
+      }
+      window.location.href = destination
+    }


Tracking can block signup

SocialSignUpCompletion makes the user's redirect depend on outside tracking code. If a vendor function throws, window.location.href never runs, and redirectStartedRef prevents another attempt. Put the redirect in a finally block so a tracking error cannot leave a signed-up user on “Finishing signup…”.

Suggested change

const finishSignUp = async () => {

if (session?.user && isSocialSignInProvider(provider)) {

await trackSocialSignUpConversions({

marker,

provider,

userId: session.user.id,

measurement: consentRequired && measurement,

marketing: consentRequired && marketing,

})

}

window.location.href = destination

}

const finishSignUp = async () => {

try {

if (session?.user && isSocialSignInProvider(provider)) {

await trackSocialSignUpConversions({

marker,

provider,

userId: session.user.id,

measurement: consentRequired && measurement,

marketing: consentRequired && marketing,

})

}

} finally {

window.location.href = destination

}

}

greptile-apps · 2026-10-18T23:58:28Z

+    const trackXEvent = vi.fn()
+    const trackGoogleEvent = vi.fn()
+    const trackFreebuffEvent = vi.fn()
+    window.twq = trackXEvent
+    window.gtag = trackGoogleEvent
+    window.freebuff = trackFreebuffEvent


Tests skip the signup journey

The social signup test replaces every vendor function with a mock and checks their calls. CLAUDE.md explicitly forbids tests that mock every collaborator and assert toHaveBeenCalledWith. Replace this with a test through the real signup boundary that checks consent, one-time reporting, and arrival at the requested page. This repository requirement must be satisfied before merging.

Context Used: CLAUDE.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

greptile-apps · 2026-10-18T23:58:28Z

+import { useConsentScript } from '@c15t/nextjs/headless'
+import { X_PIXEL_SCRIPT } from '@/lib/consent/scripts'
+
+export function SignupConsentTracking() {


Required props interfaces are missing

SignupConsentTracking has no props interface. The component guide requires one for every component. Add an explicit props interface here and to the new SocialSignUpCompletePage, which has the same omission. This repository requirement must be satisfied before merging.

Context Used: Component patterns and structure for React components (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

waleedlatif1 · 2026-10-19T00:03:09Z

@cubic review

waleedlatif1 · 2026-10-19T00:03:10Z

@greptile

cubic-dev-ai · 2026-10-19T00:03:15Z

@cubic review

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

1 issue found across 11 files

Confidence score: 3/5

A tracking error in social-sign-up-completion.tsx can leave a signed-up user stuck on “Finishing signup…” instead of redirecting. Move the redirect into a finally block.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/app/(auth)/signup/complete/social-sign-up-completion.tsx">

<violation number="1" location="apps/sim/app/(auth)/signup/complete/social-sign-up-completion.tsx:37">
P2: Put the redirect in a `finally` block so a tracking error cannot leave a signed-up user stuck on “Finishing signup…”.</violation>
</file>

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

cubic-dev-ai · 2026-10-19T00:07:06Z

+        await trackSignUpCompletionConversions({
+          marker,
+          method: provider,
+          userId: session.user.id,
+          measurement: consentRequired && measurement,
+          marketing: consentRequired && marketing,
+        })
+      }
+      window.location.href = destination
+    }


P2: Put the redirect in a finally block so a tracking error cannot leave a signed-up user stuck on “Finishing signup…”.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At apps/sim/app/(auth)/signup/complete/social-sign-up-completion.tsx, line 37: <comment>Put the redirect in a `finally` block so a tracking error cannot leave a signed-up user stuck on “Finishing signup…”.</comment> <file context> @@ -0,0 +1,62 @@ + + const finishSignUp = async () => { + if (session?.user && isSignUpConversionMethod(provider)) { + await trackSignUpCompletionConversions({ + marker, + method: provider, </file context>

Suggested change

await trackSignUpCompletionConversions({

marker,

method: provider,

userId: session.user.id,

measurement: consentRequired && measurement,

marketing: consentRequired && marketing,

})

}

window.location.href = destination

}

try {

if (session?.user && isSignUpConversionMethod(provider)) {

await trackSignUpCompletionConversions({

marker,

method: provider,

userId: session.user.id,

measurement: consentRequired && measurement,

marketing: consentRequired && marketing,

})

}

} finally {

window.location.href = destination

}

feat(analytics): report account signups to X Ads

d06b77e

vercel Bot temporarily deployed to Preview October 18, 2026 23:51 Inactive

cubic-dev-ai Bot reviewed Oct 18, 2026

View reviewed changes

Comment thread apps/sim/app/(auth)/signup/complete/social-sign-up-completion.tsx

Comment thread apps/sim/lib/analytics/sign-up.ts

greptile-apps Bot reviewed Oct 18, 2026

View reviewed changes

Pi Babysit: address PR #9212 feedback

70515f3

vercel Bot temporarily deployed to Preview October 19, 2026 00:03 Inactive

cubic-dev-ai Bot reviewed Oct 19, 2026

View reviewed changes

waleedlatif1 closed this Oct 19, 2026

waleedlatif1 deleted the feat/x-signup-conversion-20261018 branch October 19, 2026 03:21

Conversation

waleedlatif1 commented Oct 18, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

waleedlatif1 commented Oct 18, 2026

Uh oh!

waleedlatif1 commented Oct 18, 2026

Uh oh!

vercel Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot commented Oct 18, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Diagram

Uh oh!

greptile-apps Bot Oct 18, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 18, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 18, 2026

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Oct 19, 2026

Uh oh!

waleedlatif1 commented Oct 19, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 19, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Oct 18, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Oct 18, 2026 •

edited

Loading

cubic-dev-ai Bot Oct 19, 2026 •

edited

Loading