Repository navigation
fix(execution): precheck the default video target and attribute 4xx resume preprocessing refusals to the run - #9223
Merged
Conversation
…esume preprocessing refusals to the run
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
[Medium impact] The PR appears safe to merge; no new actionable issue was found. SummaryThe PR checks the default video output path before paid generation and adjusts how resume preprocessing refusals are logged.
Reviews (2) · Last reviewed commit: "fix(resume): keep retryable preprocessin..." · Reviewed by Greptile |
… run-state refusal once at info
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from the v0.9.27 release review, scoped to #9209–#9211:
generate_videovalidates its output target before calling the provider even when no output path is given. The defaultfiles/generated-video.mp4is fixed, so the check is exact; a taken default no longer costs a paid generation that then fails to save.Resume execution failedline logs at info. 5xx refusals and the corrupt paused-run 409s stay internal.oauth/startanswers 422 when an authorization server refuses) and notes v2 keeps its documented 503.Type of Change
Testing
write-target-precheck.integration.ts(real Postgres): new case runsgenerate_videotwice with no output path; the second call is refused without calling the provider or recording a charge. Fails on staging, passes with the fix (7/7).human-in-the-loop-manager.test.ts: drives the realrunResumeExecutionwith 402/404/429/500 preprocessing refusals; the three 4xx cases fail on staging and pass with the fix, 500 stays internal (93/93).model-boundaries.test.ts: resource-writer mock gains the validator, and the abort mock rejects an already-aborted signal the way the real fal queue does (throwIfAbortedbefore submit).bun run lint,check:test-patterns,check:comment-hygiene.Checklist
test-auditauthoring gate)