Skip to content

fix(execution): precheck the default video target and attribute 4xx resume preprocessing refusals to the run - #9223

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/v0927-review-followups
Oct 19, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/v0927-review-followups

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Follow-ups from the v0.9.27 release review, scoped to #9209–#9211:

  • generate_video validates its output target before calling the provider even when no output path is given. The default files/generated-video.mp4 is fixed, so the check is exact; a taken default no longer costs a paid generation that then fails to save.
  • A resume whose preprocessing refuses it with a 4xx (usage limit, rate limit, archived workflow) is attributed to the run, so its one Resume execution failed line logs at info. 5xx refusals and the corrupt paused-run 409s stay internal.
  • Discover route doc comment names the precedent it actually follows (oauth/start answers 422 when an authorization server refuses) and notes v2 keeps its documented 503.

Type of Change

  • Bug fix

Testing

  • write-target-precheck.integration.ts (real Postgres): new case runs generate_video twice with no output path; the second call is refused without calling the provider or recording a charge. Fails on staging, passes with the fix (7/7).
  • human-in-the-loop-manager.test.ts: drives the real runResumeExecution with 402/404/429/500 preprocessing refusals; the three 4xx cases fail on staging and pass with the fix, 500 stays internal (93/93).
  • model-boundaries.test.ts: resource-writer mock gains the validator, and the abort mock rejects an already-aborted signal the way the real fal queue does (throwIfAborted before submit).
  • Media, image, discover, executor and vfs suites: 326/326. bun run lint, check:test-patterns, check:comment-hygiene.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 19, 2026 8:22pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/workflows/executor/human-in-the-loop-manager.ts Outdated
@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issue was found.

Summary

The PR checks the default video output path before paid generation and adjusts how resume preprocessing refusals are logged.

  • Video generation checks the default save path before calling the provider.
  • Final 4xx resume refusals count as failures caused by the run.
  • The discovery route comment explains its 422 response.

Reviews (2) · Last reviewed commit: "fix(resume): keep retryable preprocessin..." · Reviewed by Greptile

Comment thread apps/sim/lib/workflows/executor/human-in-the-loop-manager.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 91cb0b0 into staging Oct 19, 2026
43 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/v0927-review-followups branch October 19, 2026 20:32

This branch was previously deployed

1 inactive deployment
Preview — c2524bb0 Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant