Repository navigation
chore: Remove leftovers from deprecated deployment types - #1433
Open
marcleblanc2 wants to merge 8 commits into
Open
marcleblanc2 wants to merge 8 commits into
marcleblanc2 wants to merge 8 commits into
Conversation
Docker Compose is the only deployment type this repo supports, so remove what remained for sourcegraph/server and pure-docker: - nginx/: sourcegraph/server nginx config, unreferenced since 2020 - tools/migrate.sh, tools/migration_vars: sourcegraph/server to Docker Compose DB migration; the single-container image was removed in 7.0 - tools/tools.go: pinned update-docker-tags, whose script was removed in #1249; go mod tidy drops it and dev/ci/images - TEST_TYPE plumbing in pipeline.yaml, Vagrantfile, smoke-test.sh and TESTING.md: only one test type is left - .buildkite/ci-checkov.sh: scanned Terraform, of which there is none - renovate.json rule for a Go module path that no longer exists Update README.md and TESTING.md to stop recommending the single Docker container, point at current docs URLs, and use tags instead of the removed master branch. Amp-Thread-ID: https://ampcode.com/threads/T-01a13c63-baf9-736a-839c-164204abba6c Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
changed the title
Amp-Thread-ID: https://ampcode.com/threads/T-01a13c63-baf9-736a-839c-164204abba6c Co-authored-by: Amp <amp@ampcode.com>
The local-run instructions did not work: IMAGE had no default, the vagrant-env plugin was missing, vagrant-run.sh needs sourcegraph-ci secrets rather than your own GCP account, and the manual tag-hopping upgrade test depended on TEST_TYPE on old tags. Replace them with the real requirements for vagrant-run.sh and point upgrade testing at test/upgrade-test.go. Amp-Thread-ID: https://ampcode.com/threads/T-01a13c63-baf9-736a-839c-164204abba6c Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a13c63-baf9-736a-839c-164204abba6c Co-authored-by: Amp <amp@ampcode.com>
The old operations#database-migrations URL redirected to the wrong page; the others redirected but to new paths. Amp-Thread-ID: https://ampcode.com/threads/T-01a13c63-baf9-736a-839c-164204abba6c Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a13c63-baf9-736a-839c-164204abba6c Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a13c63-baf9-736a-839c-164204abba6c Co-authored-by: Amp <amp@ampcode.com>
2 tasks done
marcleblanc2
enabled auto-merge (squash)
October 15, 2026 00:42
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker Compose is the only deployment type this repo supports. #1386 removed
pure-docker/; this removes what was still left over forsourcegraph/serverand pure-docker, plus dead CI bits and stale docs found along the way.Deleted
nginx/–sourcegraph/servernginx config, unreferenced since 2020tools/–sourcegraph/server→ Docker Compose migration script, and a pin forupdate-docker-tags(removed in Remove deprecated tools/enforce-tags and tools/update-docker-tags scripts #1249).buildkite/ci-checkov.shand its pipeline step – scanned Terraform, of which there is noneTESTING.md– the local-run instructions did not work.nvmrc– nothing reads it; CI uses.tool-versionsvia miseTEST_TYPEplumbing inpipeline.yaml,test/Vagrantfile,test/smoke-test.sh– only one test type leftasdf-checkovandshellcheckin.tool-versions,/right.dhalland nginx lines in.gitignore, arenovate.jsonrule for a Go module no longer ingo.modUpdated
README.md– rewritten for Docker Compose onlydocs.sourcegraph.comlinks in compose/config comments, READMEs, and the PR templatedb-only-migrate.docker-compose.yamlheader – it's for backup/restore, not the server migrationTest plan
go mod tidy && go vet ./... && go build -o /dev/null ./test/cleanvalidate-docker-compose,prettier-check, and thedocker-compose-testVagrant smoke test passCloses #1181