Repository navigation
Fix precise-code-intel tmpdir PVC reclaim policy - #958
Merged
Merged
Conversation
The /tmp scratch volume is a generic ephemeral volume, so its claim is created and deleted with the pod. It took its class from storageClass.name, which is reclaimPolicy Retain for stateful data. Each worker restart therefore left a Released PV and its backing disk behind, and the disks accumulated until the cloud provider's SSD quota rejected new claims. The claim now reads preciseCodeIntel.storageClassName, which defaults to empty so the cluster default class applies. Cluster defaults are reclaimPolicy Delete, so the volume is reclaimed with the pod. The value is deliberately not a concrete class name, since those differ per cloud provider. storageType defaults to emptyDir, so the default render is unchanged.
devdinu
marked this pull request as ready for review
October 8, 2026 19:34
DaedalusG
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The precise-code-intel-worker
/tmpscratch volume is a generic ephemeralvolume, so its claim is created and deleted with the pod. It took its class
from
storageClass.name, which isreclaimPolicy: Retainfor stateful data.Every worker restart left a Released PV and its backing disk behind, and the
disks accumulated until the cloud provider's SSD quota rejected new claims.
Changes
preciseCodeIntel.storageClassNamefor the/tmpscratch PVC, read instead ofstorageClass.namereclaimPolicy: Delete, so the volume is reclaimed with the podThe value is deliberately not a concrete class name. Those differ per cloud
provider (
premium-rwoon GKE,gp3on EKS,managed-csion AKS), and ahardcoded default would leave a PVC permanently Pending on clusters that do
not define it.
storageClassstaysRetainand continues to back thestateful volumes.
storageTypedefaults toemptyDir, so the default render is unchanged.Pre-existing Released PVs are not reclaimed by the upgrade. Operators already
on a Retain class need to delete those and their backing disks separately.
Test Plan