Repository navigation
docs: Fix HTTP proxy configuration for private networks - #2091
Open
marcleblanc2 wants to merge 6 commits into
Open
marcleblanc2 wants to merge 6 commits into
marcleblanc2 wants to merge 6 commits into
Conversation
- Drop migrator and executor from the services needing proxy env vars: migrator only connects to Postgres, and executor only connects to the frontend and does not pass the vars to its jobs - Fix the Docker Compose example, which wrapped the NO_PROXY value in literal quotes, and name the services instead of <service-name> - Add syntactic-code-intel-worker to the Docker Compose NO_PROXY list - Link to the outbound-http-proxy examples in the deploy repos Amp-Thread-ID: https://ampcode.com/threads/T-01a13c4a-ae1a-7319-bf11-cb792b1a5481 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Contributor
❌ This PR introduces 2 broken link(s)OutboundYour PR includes links to pages or anchors that do not exist.
Reproduce locally with Adding a redirect in |
Contributor
|
Direct preview links to pages changed in this PR: |
…ration Drops the TELEMETRY_HTTP_PROXY instructions, which duplicated the HTTPS_PROXY guidance with a narrower, frontend-only variable. Amp-Thread-ID: https://ampcode.com/threads/T-01a13c4a-ae1a-7319-bf11-cb792b1a5481 Co-authored-by: Amp <amp@ampcode.com>
This was referenced Oct 14, 2026
The example override files are validated by CI in the deploy repos and live beside the service definitions they list, so they stay current. Amp-Thread-ID: https://ampcode.com/threads/T-01a13c4a-ae1a-7319-bf11-cb792b1a5481 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a13c4a-ae1a-7319-bf11-cb792b1a5481 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a13c4a-ae1a-7319-bf11-cb792b1a5481 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a13c4a-ae1a-7319-bf11-cb792b1a5481 Co-authored-by: Amp <amp@ampcode.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the HTTP proxy guidance in
docs/self-hosted/private-network.mdxanddocs/admin/pings.mdx:Drops the incorrect and drifted YAML examples from the doc site, and replaces them with links to the
outbound-http-proxyexamples in the deployment repos (Add outbound HTTP proxy example override deploy-sourcegraph-helm#962 and Add outbound HTTP proxy example override deploy-sourcegraph-docker#1432)Drops mention of
TELEMETRY_HTTP_PROXYMerge after the two deploy repo PRs, which create the linked example files