Skip to content

XML Documentation on all public methods #35

Open

Description

@natepisarski

Issuehunt badges

The Problem

Howdy! So, I've started to play around with SqlKata on a pretty large project with a lot of team members. The existing documentation has been very helpful to get started with the basics. However, I've found myself reading the code quite a bit to get an idea of how more complex scenarios work.

The Use-Case

While this makes a case for simply beefing up the existing github website, I believe it would be more helpful to include detailed XML documentation for public members and classes. Most developers I know tend to explore a new library via:

  • An IDE, by exploring XML documentation comments in the IDE's intellisense tooltip box
  • Exploring a complete reference website, which can be generated from a project with XML documentation (doxygen). This could even be hosted on the Github site.
  • Lastly, exploring the code - which becomes clearer with XML documentation comments.

The Question

Would this be a worthwhile contribution? Some developers leave these out as a choice, as to not clutter the code itself. If this is something that would be considered helpful, I'd gladly volunteer (without any promises as to timeframe) to begin writing this documentation. Thoughts?


IssueHunt Summary

Backers (Total: $10.00)

Submitted pull Requests


Become a backer now!

Or submit a pull request to get the deposits!

Tips

Activity

  1. ahmad-moussawi commented on Dec 8, 2017

    @ahmad-moussawi
    Contributor

    Hi @natepisarski, the short answer is absolutely yes.
    But keep in mind that the package is still in beta, while the majority of the API will stay the same, I can't guarantee that the public API will not change, especially that I am planning to add many useful features to it the soonest,

    So I will appreciate in advance any effort regarding the docs 👍

  2. natepisarski commented on Dec 8, 2017

    @natepisarski
    Author

    @ahmad-moussawi That's totally okay! Updates docs after a breaking change tends to be less of an investment than writing them in the first place.

    There's approaches I've seen (that are all overkill for the current state of the project) like leaving a [Documented("12-08-2017")] and checking against a history of breaking changes automatically in the unit tests.

    Once I get a bit more well versed in the code I'll put up a documentation PR. I'd find it super helpful, and I bet plenty of people will as well. Thanks for being open to it 🥇

  3. ahmad-moussawi commented on Dec 11, 2017

    @ahmad-moussawi
    Contributor

    That really cool, please let me know if you I can help in this also

  4. IssueHuntBot commented on Sep 14, 2018

    @IssueHuntBot

    @BoostIO funded this issue with $10. Visit this issue on Issuehunt

  5. IssueHuntBot commented on Oct 9, 2018

    @IssueHuntBot
  6. Rajesh270712 commented on Jun 25, 2026

    @Rajesh270712

    Hi, I would like to work on this with a focused first pass adding XML docs for the query execution extension methods in SqlKata.Execution/Query.Extensions.cs. I validated the branch with dotnet restore, dotnet build --no-restore, an XML doc coverage script showing 62 public members and 0 missing docs, and dotnet test --no-restore --no-build --filter 'FullyQualifiedName!~MySqlExecutionTest' (334 passed, 1 skipped). The full local suite only failed the MySQL integration tests because SQLKATA_MYSQL_HOST/MySQL env is not configured locally.

    If this direction looks aligned, could you assign this issue to @Rajesh270712? I will avoid duplicating work if someone else is already handling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions