Repository navigation
Ground Assistant folder access in explicit user selections - #175
Merged
Merged
Conversation
lweberru
requested review from
Breeless,
JoshSTACKIT,
LembDo and
dweezl
as code owners
October 28, 2026 10:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A request for a folder role without a target folder could produce a proposal for the Platform folder. The full qualified Dev release of #174 caught this in governance-folder-scope (145/146 checks passed; the 13-step journey passed); deployment was blocked.
The API now grounds folder scope in the current user request and asks for a missing or ambiguous target instead of trusting classifier-selected keys or all-folders scope. A direct selection from the immediately open server-shaped folder question retains its bound role and email identity; older or discarded requests cannot authorize the selection. Existing explicit targets and additive role assignments remain supported. The user guide documents the behavior in both languages.
Validation: full local check passes (1,360 tests; 76 expected skips); 170 focused editor/governance unit tests and typecheck pass. All eight affected governance model cases passed twice under the final knowledge/source binding (16/16), including the reported missing-target failure and direct selection continuation. Independent review covered role/identity preservation, organization-role escalation, old/discarded history, dynamic folder names, multi-selection and negated scope. All applicable GitHub CI checks passed, including the full application/database/browser flow. Merged as a05d2d7. Qualified release 40673628401 passed all 148/148 real-model checks and the 13/13-step journey and built the immutable artifacts. Its deployment was interrupted during Runner upload. Promotion 40681508056 reused those qualified artifacts without rebuilding or repeating model checks and deployed successfully with runner_pool_size=1 and build_only=false, including runner isolation, assignment and replenishment checks. No production or customer infrastructure execution is included.