Repository navigation
fix(runner): retire already reconciled recovery runners - #177
Merged
Merged
Conversation
lweberru
requested review from
Breeless,
JoshSTACKIT,
LembDo and
dweezl
as code owners
October 28, 2026 13:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recovered warm Runner could remain desired STARTED/CRASHED indefinitely because normal pool retirement only accepted succeeded/failed dispatches, while a reconciled interruption retains reconciliation_required as historical status.
Retirement now also accepts the existing validated recovery-replan clearance after Runner tickets expire and with no active guided recovery. Exact space/origin/job/app/package bindings remain mandatory. The stopped-app sweeper uses the same established validator instead of checking only receipt existence, preserving protection when a later separate recovery State invalidates clearance. Historical migrations are unchanged; the additive migration is 077.
Validation: 69 PostgreSQL identity, isolation, recovery and retention tests pass. The actual cleared-apply fixture tests expired authority positively and live tickets/missing clearance negatively, with rollback preserving later recovery assertions. Independent review found no remaining issues. English/German operations documentation is updated. This follow-up changes no Assistant implementation, knowledge, intent schema or qualification oracle; the Assistant qualification for parent #176 remains separately required before the combined Dev deployment. No production or customer Plan/Apply/State/lock mutation is included.