Skip to content

Remove stackpop references for the IABTechLab transfer - #419

Open
aram356 wants to merge 5 commits into
mainfrom
chore/move-to-iabtechlab
Open

aram356 wants to merge 5 commits into
mainfrom
chore/move-to-iabtechlab

Conversation

@aram356

@aram356 aram356 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • EdgeZero is moving to the IABTechLab org by repository transfer. After this PR, git grep -i stackpop returns nothing.
  • The transfer redirects github.com/stackpop/edgezero. It does not redirect the GitHub Pages site, and it does not carry over org-level project boards or issue types. Those are the parts that would actually break.

Changes

Crate / File Change
edgezero-cli generator.rs, adapter cli.rs (fastly, cloudflare, spin, axum) Git fallbacks for edgezero new point at IABTechLab/edgezero.git. The Fastly schema-drift error links to the IABTechLab issue tracker.
README.md, docs/, README.md.hbs template Docs links move to iabtechlab.github.io/edgezero. Repo links and uses: examples move to IABTechLab/edgezero.
.github/actions/deploy-core/tests/run.sh The structural docs assertion matches the new uses: refs.
.github/dependabot.yml Removes a URL that had been pasted into the first comment line.
.claude/agents/{issue,pr}-creator.md, pr-reviewer.md Point at the Trusted Server Development board and the IABTechLab issue-type, field, and status IDs. The status option IDs differ between orgs (stackpop's Backlog ID is IABTechLab's Ready), so the table was remapped by name.
LICENSE, docs footer Copyright holder becomes IAB Technology Laboratory, Inc., matching IABTechLab/trusted-server.

Three commits: URLs, agent configs, copyright. Any one of them can be reverted on its own.

For reviewers

  • Copyright holder. Please confirm "IAB Technology Laboratory, Inc." is the right holder for EdgeZero. It is isolated in the last commit.
  • Project board. IABTechLab has one open project, Trusted Server Development, so the agents now target it.
  • Merge timing. Merge right after the transfer. The IABTechLab/... URLs and the agent board IDs only resolve once the repo lives there.
  • Outside the repo. Update the repo's About homepage (stackpop.github.io/edgezero) after the transfer, and check that Pages is still enabled. Downstream pins such as trusted-server's git = "https://github.com/stackpop/edgezero" keep working through the redirect, but should be updated.

Closes

Closes #418

Test plan

  • cargo test --workspace --all-targets
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo fmt --all -- --check
  • cargo check --workspace --all-targets --features "fastly cloudflare spin"
  • WASM builds: wasm32-wasip2 (Spin) only
  • examples/app-demo workspace: no changes there
  • Docs build: cd docs && npm run lint && npm run format && npm run build
  • Manual testing via edgezero serve --adapter axum: no runtime behavior changed
  • Other: .github/actions/deploy-core/tests/run.sh passes 639 with 0 failures, the same as on main. A CLI built away from its source tree generated a project whose six git dependencies all point at IABTechLab/edgezero.git.

Checklist

  • Changes follow CLAUDE.md conventions
  • No Tokio deps added to core or adapter crates
  • Route params use {id} syntax (not :id)
  • Types imported from edgezero_core (not http crate)
  • Store wiring goes through KvRegistry / ConfigRegistry / SecretRegistry (not the legacy single-handle setters) — see spec §6.6
  • New code has tests: no new code
  • No secrets or credentials committed

EdgeZero is moving to the IABTechLab org by repository transfer. The
transfer redirects github.com/stackpop/edgezero, but not the GitHub
Pages site, so docs links move to iabtechlab.github.io/edgezero. Repo
URLs, action uses: examples, and the generator's git fallbacks move to
IABTechLab/edgezero so new projects do not depend on the redirect.

Refs #418
Org-level projects and issue types do not move with a repository
transfer. Point issue-creator and pr-creator at the Trusted Server
Development board and the IABTechLab issue type IDs.

Refs #418
Matches the holder used by IABTechLab/trusted-server.

Refs #418
@aram356 aram356 self-assigned this Oct 13, 2026
@aram356
aram356 requested review from ChristianPavilonis, dhruv8sh and prk-Jr and removed request for dhruv8sh and prk-Jr October 13, 2026 17:58

@ChristianPavilonis ChristianPavilonis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The reference updates align with the planned transfer to IABTechLab.

@prk-Jr prk-Jr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

Summary

Mechanical org-transfer cleanup, done carefully. git grep -i stackpop at afbbef68 is empty, and the issue-type, project, field, and status option IDs match IABTechLab/trusted-server's agent configs exactly (including the Backlog/Ready swap). Approving; the notes below are non-blocking.

😃 Praise

  • Remapping status option IDs by name instead of copying them; the Backlog/Ready ID swap between orgs is easy to miss.
  • Three independently revertible commits, and the zero-stackpop claim holds.

Findings

Non-blocking

  • 🤔 Pre-transfer copyright notice: Apache-2.0 §4(c) asks derivative works to retain existing copyright notices. Unless Stackpop assigned copyright to IAB Tech Lab, consider keeping both holders (LICENSE:189, docs footer).
  • 🤔 Feature issue type missing from the agent type tables (issue-creator.md, pr-creator.md).
  • 🏕 https://git@github.com/... fallbacks: the git@ userinfo is meaningless over HTTPS; the docs already use plain https://github.com/IABTechLab/edgezero.git. Applies to all 13 fallback strings across the adapter cli.rs files and generator.rs.
  • 🏕 Spec/plan links point at repo root (blob-app-config-migration.md:414-415).
  • ⛏ Historical plan doc rewritten with an invented ci@edgezero.dev address.
  • 📝 Merge triggers a docs deploy: deploy-docs.yml runs on pushes to main touching docs/**. Merging before the transfer would rebuild the stackpop Pages site with links that do not resolve yet, which reinforces the "merge right after transfer" note.

📌 Out of Scope

  • IABTechLab/trusted-server Cargo.toml / Cargo.lock pin stackpop/edgezero. Cargo treats a changed git URL as a new source, so switching it belongs in its own trusted-server PR.

CI Status

  • fmt: PASS
  • clippy: PASS
  • tests: PASS

Comment thread LICENSE
Comment thread .claude/agents/issue-creator.md
Comment thread crates/edgezero-cli/src/generator.rs Outdated
Comment thread docs/guide/blob-app-config-migration.md
Comment thread docs/superpowers/plans/2026-08-20-build-cache-container.md
Comment thread .github/dependabot.yml
The fallbacks moved from ssh://git@github.com to https:// in #159 and
kept the SSH username, which means nothing over HTTPS. Use the plain
form the docs already show.

Refs #418
@aram356

aram356 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Pushed e445203 (plain https:// fallbacks) and 6b849f3 (spec and plan links). Agreed on the docs deploy trigger. This merges right after the transfer, so the Pages rebuild lands on the IABTechLab site. The trusted-server pin switch goes in its own PR there.

@dhruv8sh dhruv8sh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

Summary

This is a mechanical, well-scoped rename for the IABTechLab transfer. I verified it against the live IABTechLab resources: the Trusted Server Development project, Status field and all six status option IDs match the board, the five issue-type IDs match the types exposed by IABTechLab/trusted-server, and IABTechLab has no custom domain on its org Pages, so iabtechlab.github.io/edgezero/ will resolve (iabtechlab.github.io/trusted-server/ already serves 200). Nothing blocking.

😃 Praise

  • The status table was remapped by name rather than copied over by ID. That avoids a real trap: f75ad846 is Backlog on the stackpop board but Ready on the IABTechLab one.
  • Removing the stray git@ userinfo from the https:// git fallbacks fixes an odd URL while renaming it.
  • The blob app-config spec and plan links now point at the actual files instead of the repo root.
  • The commits are split so the URL, agent-config and copyright changes can each be reverted on their own.

Findings

Non-blocking

  • 🤔 "Defaults to Backlog" may no longer hold (.claude/agents/issue-creator.md:60, inline)
  • 🤔 The new "Won't Fix" status isn't excluded from the move to In progress (.claude/agents/pr-creator.md:96, anchored at the table row on line 133, inline)
  • 📝 Copyright holder: on your question, IABTechLab/trusted-server's LICENSE reads "Copyright 2018 IAB Technology Laboratory, Inc.", so the holder name matches. The final call still belongs to whoever has authority over the copyright.

📌 Out of Scope

  • Auto-add won't cover edgezero issues: the stackpop board had a dedicated "Auto-add to project (edgezero)" workflow. The IABTechLab board has one generic "Auto-add to project" workflow, which is probably filtered to trusted-server. After the transfer, new edgezero issues won't land on the board unless someone adds or widens that filter in the board settings. Worth adding to the list of changes to make outside the repo.

CI Status

  • fmt: PASS
  • clippy: PASS
  • tests: PASS

### 5. Add to project board

Add the issue to the **Stackpop Development** project (defaults to
Add the issue to the **Trusted Server Development** project (defaults to

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 "Defaults to Backlog" may no longer hold: the IABTechLab board has an "Item added to project" workflow turned on, and the API doesn't show which status it sets. stackpop's Backlog ID (f75ad846) is IABTechLab's Ready ID, which suggests the board was cloned and Backlog was added later. If so, the workflow may still put new items in Ready.

Fix: confirm the workflow's target status in the board settings, or set Backlog explicitly after addProjectV2ItemById:

value: { singleSelectOptionId: "8b41a45a" }

| In review | `df73e18b` |
| In review | `4424127f` |
| Done | `98236657` |
| Won't Fix | `b622b030` |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 The new "Won't Fix" status isn't handled: Step 2 (line 96) only skips moving the issue to In progress when it is already "In review" or "Done". A PR linked to an issue closed as Won't Fix would move it back to In progress.

Fix: add "Won't Fix" to the skip list in step 2 and in the matching sentence at line 75, e.g. If current status is not "In review", "Done", or "Won't Fix", ...

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove stackpop references for the IABTechLab transfer

4 participants