Repository navigation
Conversation
EdgeZero is moving to the IABTechLab org by repository transfer. The transfer redirects github.com/stackpop/edgezero, but not the GitHub Pages site, so docs links move to iabtechlab.github.io/edgezero. Repo URLs, action uses: examples, and the generator's git fallbacks move to IABTechLab/edgezero so new projects do not depend on the redirect. Refs #418
Org-level projects and issue types do not move with a repository transfer. Point issue-creator and pr-creator at the Trusted Server Development board and the IABTechLab issue type IDs. Refs #418
Matches the holder used by IABTechLab/trusted-server. Refs #418
ChristianPavilonis
left a comment
There was a problem hiding this comment.
Approved. The reference updates align with the planned transfer to IABTechLab.
prk-Jr
left a comment
There was a problem hiding this comment.
PR Review
Summary
Mechanical org-transfer cleanup, done carefully. git grep -i stackpop at afbbef68 is empty, and the issue-type, project, field, and status option IDs match IABTechLab/trusted-server's agent configs exactly (including the Backlog/Ready swap). Approving; the notes below are non-blocking.
😃 Praise
- Remapping status option IDs by name instead of copying them; the Backlog/Ready ID swap between orgs is easy to miss.
- Three independently revertible commits, and the zero-
stackpopclaim holds.
Findings
Non-blocking
- 🤔 Pre-transfer copyright notice: Apache-2.0 §4(c) asks derivative works to retain existing copyright notices. Unless Stackpop assigned copyright to IAB Tech Lab, consider keeping both holders (LICENSE:189, docs footer).
- 🤔 Feature issue type missing from the agent type tables (issue-creator.md, pr-creator.md).
- 🏕
https://git@github.com/...fallbacks: thegit@userinfo is meaningless over HTTPS; the docs already use plainhttps://github.com/IABTechLab/edgezero.git. Applies to all 13 fallback strings across the adaptercli.rsfiles andgenerator.rs. - 🏕 Spec/plan links point at repo root (blob-app-config-migration.md:414-415).
- ⛏ Historical plan doc rewritten with an invented
ci@edgezero.devaddress. - 📝 Merge triggers a docs deploy:
deploy-docs.ymlruns on pushes to main touchingdocs/**. Merging before the transfer would rebuild the stackpop Pages site with links that do not resolve yet, which reinforces the "merge right after transfer" note.
📌 Out of Scope
IABTechLab/trusted-serverCargo.toml/Cargo.lockpinstackpop/edgezero. Cargo treats a changed git URL as a new source, so switching it belongs in its own trusted-server PR.
CI Status
- fmt: PASS
- clippy: PASS
- tests: PASS
dhruv8sh
left a comment
There was a problem hiding this comment.
PR Review
Summary
This is a mechanical, well-scoped rename for the IABTechLab transfer. I verified it against the live IABTechLab resources: the Trusted Server Development project, Status field and all six status option IDs match the board, the five issue-type IDs match the types exposed by IABTechLab/trusted-server, and IABTechLab has no custom domain on its org Pages, so iabtechlab.github.io/edgezero/ will resolve (iabtechlab.github.io/trusted-server/ already serves 200). Nothing blocking.
😃 Praise
- The status table was remapped by name rather than copied over by ID. That avoids a real trap:
f75ad846is Backlog on the stackpop board but Ready on the IABTechLab one. - Removing the stray
git@userinfo from thehttps://git fallbacks fixes an odd URL while renaming it. - The blob app-config spec and plan links now point at the actual files instead of the repo root.
- The commits are split so the URL, agent-config and copyright changes can each be reverted on their own.
Findings
Non-blocking
- 🤔 "Defaults to Backlog" may no longer hold (
.claude/agents/issue-creator.md:60, inline) - 🤔 The new "Won't Fix" status isn't excluded from the move to In progress (
.claude/agents/pr-creator.md:96, anchored at the table row on line 133, inline) - 📝 Copyright holder: on your question,
IABTechLab/trusted-server's LICENSE reads "Copyright 2018 IAB Technology Laboratory, Inc.", so the holder name matches. The final call still belongs to whoever has authority over the copyright.
📌 Out of Scope
- Auto-add won't cover edgezero issues: the stackpop board had a dedicated "Auto-add to project (edgezero)" workflow. The IABTechLab board has one generic "Auto-add to project" workflow, which is probably filtered to trusted-server. After the transfer, new edgezero issues won't land on the board unless someone adds or widens that filter in the board settings. Worth adding to the list of changes to make outside the repo.
CI Status
- fmt: PASS
- clippy: PASS
- tests: PASS
| ### 5. Add to project board | ||
|
|
||
| Add the issue to the **Stackpop Development** project (defaults to | ||
| Add the issue to the **Trusted Server Development** project (defaults to |
There was a problem hiding this comment.
🤔 "Defaults to Backlog" may no longer hold: the IABTechLab board has an "Item added to project" workflow turned on, and the API doesn't show which status it sets. stackpop's Backlog ID (f75ad846) is IABTechLab's Ready ID, which suggests the board was cloned and Backlog was added later. If so, the workflow may still put new items in Ready.
Fix: confirm the workflow's target status in the board settings, or set Backlog explicitly after addProjectV2ItemById:
value: { singleSelectOptionId: "8b41a45a" }
| | In review | `df73e18b` | | ||
| | In review | `4424127f` | | ||
| | Done | `98236657` | | ||
| | Won't Fix | `b622b030` | |
There was a problem hiding this comment.
🤔 The new "Won't Fix" status isn't handled: Step 2 (line 96) only skips moving the issue to In progress when it is already "In review" or "Done". A PR linked to an issue closed as Won't Fix would move it back to In progress.
Fix: add "Won't Fix" to the skip list in step 2 and in the matching sentence at line 75, e.g. If current status is not "In review", "Done", or "Won't Fix", ...
Summary
git grep -i stackpopreturns nothing.github.com/stackpop/edgezero. It does not redirect the GitHub Pages site, and it does not carry over org-level project boards or issue types. Those are the parts that would actually break.Changes
edgezero-cligenerator.rs, adaptercli.rs(fastly, cloudflare, spin, axum)edgezero newpoint atIABTechLab/edgezero.git. The Fastly schema-drift error links to the IABTechLab issue tracker.README.md,docs/,README.md.hbstemplateiabtechlab.github.io/edgezero. Repo links anduses:examples move toIABTechLab/edgezero..github/actions/deploy-core/tests/run.shuses:refs..github/dependabot.yml.claude/agents/{issue,pr}-creator.md,pr-reviewer.mdLICENSE, docs footerIABTechLab/trusted-server.Three commits: URLs, agent configs, copyright. Any one of them can be reverted on its own.
For reviewers
IABTechLab/...URLs and the agent board IDs only resolve once the repo lives there.stackpop.github.io/edgezero) after the transfer, and check that Pages is still enabled. Downstream pins such as trusted-server'sgit = "https://github.com/stackpop/edgezero"keep working through the redirect, but should be updated.Closes
Closes #418
Test plan
cargo test --workspace --all-targetscargo clippy --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkcargo check --workspace --all-targets --features "fastly cloudflare spin"wasm32-wasip2(Spin) onlyexamples/app-demoworkspace: no changes therecd docs && npm run lint && npm run format && npm run buildedgezero serve --adapter axum: no runtime behavior changed.github/actions/deploy-core/tests/run.shpasses 639 with 0 failures, the same as onmain. A CLI built away from its source tree generated a project whose six git dependencies all point atIABTechLab/edgezero.git.Checklist
{id}syntax (not:id)edgezero_core(nothttpcrate)KvRegistry/ConfigRegistry/SecretRegistry(not the legacy single-handle setters) — see spec §6.6