Repository navigation
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JWk616aRCqjJE8a6APAnsC --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
blas/base/zscalfrom relative tolerance testing (delta <= rtol * EPS * abs( expected )) to ULP difference testing using@stdlib/assert/is-almost-same-value.EPS/absimports withisAlmostSameValueand updates the privateisApproxtest helper to accept a maximum allowed ULP difference, matching the idiom used in already migrated sibling packages (e.g.,blas/base/wasm/zscalandblas/base/zaxpy).Files changed (test files only):
test/test.zscal.jstest/test.zscal.native.jstest/test.ndarray.jstest/test.ndarray.native.jsMeasured minimum ULP bounds (per test case, in file order):
test/test.zscal.js1,4,4,2test/test.zscal.native.js1,4,4,2test/test.ndarray.js1,4,4,10,10test/test.ndarray.native.js1,4,4,10,10Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
The native test suites could not be executed locally, as the native add-on was not built in the development environment (the suites were skipped via
tryRequire). Following the convention in previously migrated packages, the native test files use the same per-test-case ULP values as their JavaScript counterparts. Please flag if the C implementation is expected to diverge for any of these cases.Other
How the bounds were determined:
@stdlib/number/float64/base/ulp-difference.N, the suite passes; atN-1, the corresponding test case fails.test/test.js: 5 passing,test/test.zscal.js: 52 passing,test/test.ndarray.js: 73 passing, 0 failing).make lint-javascript-tests TESTS_FILTER=".*/blas/base/zscal/.*"is clean.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, running as an unattended automated task. The test migration, the ULP measurements, and the minimality verification were performed by Claude Code; the approach mirrors the idiom established in previously merged migrations for this package family.
@stdlib-js/reviewers
Generated by Claude Code