Repository navigation
chore: fix JavaScript lint errors (issue #16201) - #16202
Open
wanjinhao1 wants to merge 1 commit into
Open
wanjinhao1 wants to merge 1 commit into
wanjinhao1 wants to merge 1 commit into
Conversation
stdlib-bot
added
First-time Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #16201.
Description
This pull request:
no-restricted-syntaxlint error in@stdlib/string/base/percent-encode/lib/main.js(line 91) by replacing theString.prototype.toUpperCase()call with the@stdlib/string/base/uppercaseutility, as instructed by the lint rule message.Related Issues
This pull request has the following related issues:
Questions
No.
Other
Verified by running the module directly (
node -e):percentEncode('a b~ç=/')returns'a%20b~%C3%A7%3D%2F'andpercentEncode('ABCxyz09-._~')returns'ABCxyz09-._~'(unreserved characters untouched, percent-encoded octets uppercased as before). Also confirmed via ESLint that noString.prototype.toUpperCaseusage remains in the file. The repository tape-based test suite could not be run locally due to a git-basedtapedev dependency that fails to install in this environment; behavior is unchanged as only the uppercase mechanism was swapped for an equivalent stdlib utility.This pull request was prepared with AI assistance (Claude) and reviewed by the contributor.