Repository navigation
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018M8vusnJua7pDPaBrZoE9v
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/nanmvariancefrom relative tolerance testing to ULP difference testing.delta/tolcomputations (tol = EPS * expected) intest/test.jswithisAlmostSameValueassertions, adds the@stdlib/assert/is-almost-same-valuerequire, and drops the now unused@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires.0for both migrated assertions. Starting from64and tightening,0is the measured minimum which still passes: the accumulator reproduces both expected values (19.0and12.666666666666666) exactly. This matches the ULP value used by the already migrated sibling packagestats/incr/mvariance, which exercises the same input data.Only test files are modified. The package test suite (406 assertions) passes, and the suite was run twice at the final ULP value to confirm determinism.
Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verification performed:
make test TESTS_FILTER=".*/stats/incr/nanmvariance/.*"→ 406 passing, 0 failing (run twice at ULP0, identical results).make lint-javascript-tests TESTS_FILTER=".*/stats/incr/nanmvariance/.*"→ clean.isAlmostSameValue( actual, expected, 0 )returnsfalsewhen the expected value is perturbed by one ULP.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, which located the candidate package, mirrored the idiom used by already migrated packages, and determined the minimum ULP bound empirically by running the package test suite.
@stdlib-js/reviewers
Generated by Claude Code