Skip to content

test: migrate stats/base/dists/rayleigh/logpdf to ULP-based assertions - #16207

Draft
Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-rayleigh-logpdf
Draft

Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-rayleigh-logpdf

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • migrates the tests in @stdlib/stats/base/dists/rayleigh/logpdf (test/test.logpdf.js) from computed EPS-based tolerances to ULP-based assertions via @stdlib/assert/is-almost-same-value, with the ULP count passed inline as an integer literal.
  • removes the now-unused abs and EPS requires and delta/tol variables.

Final inline ULP values (each tightened to the measured minimum that passes over the full fixture set; results were identical across two consecutive runs):

Test Fixture Old tolerance ULP Measured minimum
small scale parameter sigma small_scale.json 15 * EPS * abs(expected) 24 24
medium scale parameter sigma medium_scale.json 3 * EPS * abs(expected) 2 2
large scale parameter sigma large_scale.json 3 * EPS * abs(expected) 2 2

test/test.js and test/test.native.js contain no tolerance logic and are unchanged.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code.


@stdlib-js/reviewers


Generated by Claude Code

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Oct 17, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/rayleigh/logpdf $\\color{green}297/297$
$\\color{green}+100.00\\%$
$\\color{green}29/29$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}297/297$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants