Repository navigation
Conversation
Replaces relative tolerance assertions with ULP difference assertions using `@stdlib/assert/is-almost-same-value`. The minimum required ULP value is 1. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KVTmUPh36ZLvuBh6uP6b3t
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
constants/float64/ln-sqrt-two-pifrom relative tolerance assertions to ULP difference assertions, as proposed in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.Specifically, in
test/test.js:@stdlib/assert/is-almost-same-valuerequire.@stdlib/math/base/special/absand@stdlib/constants/float64/epsrequires.delta/toltolerance computation and replacest.ok( delta <= tol, ... )witht.strictEqual( isAlmostSameValue( v, LN_SQRT_TWO_PI, 1 ), true, 'returns expected value' ).The package has no
test/test.native.js, sotest/test.jsis the only changed file.Final ULP constant:
1. This is the measured minimum.ln( sqrt( TWO_PI ) )evaluates to0.91893853320467266954, while the exported constant is0.91893853320467278056— a difference of exactly one ULP, so the assertion fails at0and passes at1. The bound was found by starting high and tightening down to the smallest passing integer, and the suite was run twice at1to confirm the result is deterministic (no FMA/architecture-dependent variation).This change mirrors the idiom established in the sibling package
constants/float32/ln-sqrt-two-pi(#16155), which used0because its single-precision computation happens to be exact.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verification performed:
make test TESTS_FILTER=".*/constants/float64/ln-sqrt-two-pi/.*"— 4/4 passing, run twice at the final ULP value.0fails (1 failing), confirming1is the minimum.make lint-javascript-tests TESTS_FILTER=".*/constants/float64/ln-sqrt-two-pi/.*"— clean.One note for reviewers: the
lint-editorconfig-filesstep could not be executed in the environment used to author this change, because theeditorconfig-checkerbinary is fetched from GitHub releases at runtime and that download was not permitted. The EditorConfig rules applicable to*.jswere instead verified by hand on the changed file (LF line endings, UTF-8, tab indentation, no trailing whitespace, final newline present). Please re-run that step in CI.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as an unattended scheduled task. Claude selected the package, mirrored the idiom from already-merged conversions in the same family, performed the edit, and measured the minimum ULP bound empirically.
@stdlib-js/reviewers
Generated by Claude Code