Repository navigation
Install the command line programs as console_scripts - #231
Merged
Merged
Conversation
The jsondiff and jsonpatch programs were installed as extension-less scripts with a shebang line, which cannot be run on Windows. Move them from bin/ into the new module jsonpatch_cli and install them as console_scripts entry points, for which the installer generates a launcher suitable for the platform. jsonpatch.py stays a single module. The program names are set explicitly, so --version and --help print "jsondiff" and "jsonpatch" no matter how the programs are started. Based on #177. Fixes #176 Co-authored-by: Travis LaGrone <TLagrone@reyesholdings.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SMPzBWARECp9uGKGvqiyDW
stefankoegl
force-pushed
the
claude/epic-einstein-apfbsl
branch
from
October 10, 2026 21:27
99d612c to
cfbcbc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176. Based on #177, but keeps
jsonpatch.pya single module.The
jsondiffandjsonpatchprograms were installed as extension-less scripts with a shebang line (scripts=in setup.py), which cannot be run on Windows. They are now installed asconsole_scriptsentry points, for which pip generates a launcher suitable for the platform (.exeon Windows).Changes
bin/jsondiffandbin/jsonpatchare merged into the new top-level modulejsonpatch_cli.py, withjsondiff_main()andjsonpatch_main()as entry points. The code is unchanged except for renaming the names that would collide in one module (parser,main).setup.pyaddsjsonpatch_clitopy_modulesand replacesscripts=withentry_points.progexplicitly, so--versionand--helpprintjsondiff/jsonpatchno matter how the programs are started.bin/scripts.jsonpatch.py, the release workflow andRELEASING.mdare untouched. Coverage stays at 100%, becausejsonpatch_cliis outsidesource = jsonpatch, asbin/was.Testing
tests.py,property_tests.pyand pytest pass.jsonpatch.py,jsonpatch_cli.pyand theconsole_scriptsentry points.jsondiffandjsonpatch: exit codes,--version,-u, the patch read from stdin, and-i -ball work.🤖 Generated with Claude Code
https://claude.ai/code/session_01SMPzBWARECp9uGKGvqiyDW