Skip to content

Fix TSan CI build for develop, cantera - #2991

Merged
bigfooted merged 1 commit into
developfrom
fix_cantera_tsan
Oct 23, 2026
Merged

bigfooted merged 1 commit into
developfrom
fix_cantera_tsan

Conversation

@bigfooted

@bigfooted bigfooted commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

The "FATAL: ThreadSanitizer: unexpected memory mapping" message comes from the TSan runtime. It happens when the kernel's ASLR randomization is too high for TSan's fixed shadow-memory layout (vm.mmap_rnd_bits=32). That is the default on recent GitHub runner images and kernels.
The failing step is the bootstrap of ninja, because the Cantera subproject builds its own ninja when none is on the PATH. The TSan flags from the job are inherited by that bootstrap. The freshly built ./ninja is therefore TSan-instrumented and dies on startup with exit status 66, which gives the Python traceback you see.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted bigfooted changed the title Fix TSan CI build: keep sanitizer flags out of ninja bootstrap, lower… Fix TSan CI build for cantera Oct 23, 2026
… ASLR entropy

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@bigfooted bigfooted changed the title Fix TSan CI build for cantera Fix TSan CI build for develop, cantera Oct 23, 2026
@bigfooted
bigfooted merged commit 2dc7b70 into develop Oct 23, 2026
39 checks passed
@bigfooted
bigfooted deleted the fix_cantera_tsan branch October 23, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant