Repository navigation
Conversation
brainrake
force-pushed
the
martonboros/psql-1530-prestart-site-extensions
branch
from
September 8, 2026 01:43
bc047fd to
7be60e5
Compare
brainrake
added a commit
that referenced
this pull request
Oct 22, 2026
Exercises the real postgres_prestart.sh -> site-extensions-update -> site-extensions profile path from #2324. Last assertion fails on purpose: dynamic_library_path/extension_control_path aren't wired to /nix/var/nix/profiles/site-extensions yet. Refs: MPG-32 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
brainrake
changed the title
…-update postgres_prestart.sh's handle_extension_versions() now calls site-extensions-update directly instead of looping switch_<ext>_version per extension -- that resolve/download/install pipeline now lives in the nix packages added by #2317. Manifest-missing guard preserved; failure is non-fatal (matches existing behavior, and ExecStartPre already ignores exit status via the -+ prefix). Also fixes drift in postgresql.service: it had fallen out of sync with salt's live copy of the unit (ExecStartPre missing the "-" ignore-failure prefix, ReadOnlyPaths missing /usr/local). Both now match what's actually deployed on the fleet.
Matches the rename in #2424.
Refs: MPG-32 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Refs: MPG-32 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
brainrake
force-pushed
the
martonboros/psql-1530-prestart-site-extensions
branch
from
October 22, 2026 21:12
9db259c to
92e1de7
Compare
PostgreSQL Extension Dependency Analysis: PR #2324
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2324
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency ClosureOrioleDB 17 Dependency Cha...[Comment body truncated] |
Package version diffCompares built package versions in legacyPackages between this PR and the tip of the base branch, per system. aarch64-linux: Closure size: 73 -> 18 (2 paths added, 57 paths removed, delta -55, disk usage -115.4MiB).x86_64-linux: Closure size: 74 -> 18 (2 paths added, 58 paths removed, delta -56, disk usage -114.2MiB). |
Exercises the real postgres_prestart.sh -> update-site-extensions -> site-extensions profile path end to end. Last assertion fails on purpose: nothing wires dynamic_library_path/extension_control_path to /nix/var/nix/profiles/site-extensions, so without that, this branch makes extension-version pinning silently inert in production. Refs: MPG-32 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
brainrake
force-pushed
the
martonboros/psql-1530-prestart-site-extensions
branch
from
October 22, 2026 21:28
92e1de7 to
13916c6
Compare
Refs: MPG-32 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PSQL-1530.
postgres_prestart.sh'shandle_extension_versions()now delegates toupdate-site-extensionsinstead of loopingswitch_<ext>_versionper extension.postgresql.service:ReadOnlyPathsgains/usr/localto match salt's live copy.ExecStartPrehas no-prefix, so a failed extension update stops postgres from starting.Also blocked on: Postgres's
dynamic_library_path/extension_control_pathneeds thesite-extensionsprofile path added (drafted in the PSQL-1530 issue's migration plan, not yet implemented).