Repository navigation
Propose basic session API shape - #893
Merged
THardy98 merged 3 commits intoOct 27, 2026
Merged
Conversation
Rename WorkerSessionOptions' oneof to admission, document single-session binding semantics, and model activity placement as a oneof with an Empty workflow_session member in place of bool use_workflow_session. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Shivs11
approved these changes
Oct 23, 2026
Shivs11
left a comment
Shivs11
left a comment
Member
There was a problem hiding this comment.
gonna approve this, but just one comment that might need ur attention
ShahabT
reviewed
Oct 26, 2026
Comment on lines
+44
to
+45
| // workflow_session requires the activity's task queue to be the workflow's, | ||
| // and the workflow's worker to serve sessions. |
Contributor
There was a problem hiding this comment.
nit: this should move down to the workflow_sesison field.
Also, to be clear, we do want to allow cross-TQ in the future.
THardy98
force-pushed
the
session-api-basic-shape
branch
from
October 27, 2026 16:33
cf720e0 to
ededaff
Compare
THardy98
merged commit Oct 27, 2026
d183f54
into
sticky-activity-session-options
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Basically just a single field change and some comment changes based on a Notion doc proposal.
Why?
Breaking changes
Server PR