Skip to content

test: wait for the Nexus update target to close before the update that must fail #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tconley1428 merged 3 commits into from
Oct 23, 2026
Merged

test: wait for the Nexus update target to close before the update that must fail #2012

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
707b8b8
Waited for the target workflow to close before the update that must f…
moetemp Sep 29, 2026
d6ffbab
Merge branch 'main' into moe/nexus-update-wait-for-close
tconley1428 Oct 22, 2026
735d9c7
Merge branch 'main' into moe/nexus-update-wait-for-close
moetemp Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/nexus/test_temporal_operation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,10 @@ async def run_update(i: int) -> str:

async def check_updates_on_completed_workflows_fail():
"""The handler workflow already finished at this point, further updaes should just fail"""
# The last update's result does not mean the target has closed yet.
# An update that lands before the closure stays pending instead of
# failing.
await target_handle.result()
wf_handle = await client.start_workflow(
UpdateWorkflowCaller.run,
Input(
Expand Down
Loading