Repository navigation
Preserve augmented-assignment results in the workflow sandbox - #2018
Merged
tconley1428 merged 1 commit intoOct 26, 2026
Merged
Conversation
Keep restricted replacement objects and mutable proxy identity. Assisted-by: OpenAI Codex Signed-off-by: JackyHsu-X <xv1070733106@gmail.com>
|
|
tconley1428
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Preserve the result of augmented assignments in the workflow sandbox. Keep the existing proxy for an object mutated in place; wrap a replacement with the same restrictions and context; return primitive results normally. Old aliases retain their original value.
Why?
#1706 fixed the in-place-operation binder and preserved proxies for mutable objects, but its wrapper discards the operator's return value. In a sandboxed workflow:
pathstays atrootinstead of becomingroot/child. Tuple+=/*=and frozenset|=are affected too. This fixes the remaining regression while retaining #1706's mutable-list behavior.Checklist
Related: fix: preserve restricted proxies after in-place operations #1706. This is a narrow bug fix, with no existing issue to close.
How was this tested:
poe test tests/worker/workflow_sandbox -n 0 -ra: 35 passed, 1 existing Python-version skip, including a real local Temporal service and Worker.poe lint-docspasses.Tested on Windows/Python 3.13 using checkout Python sources and the unchanged native bridge from the matching
temporalio==1.34.0wheel. The Rust bridge was not rebuilt; the full repository and other OS/Python matrices were not run.Any docs updates needed?
Added
changelog/fixed/joining-pathfinder.md. No public API signature changes.AI assistance
OpenAI Codex assisted with investigation, implementation, regression tests, validation, and this description. Codex performed the technical self-review; no human review is claimed.