Repository navigation
Remove the size limit on the compiled pattern cache - #16
Merged
vzakaznikov merged 1 commit intoOct 22, 2026
Merged
Conversation
Each step matches every live xfails/ffails pattern twice, so more than 128 live patterns overflow maxsize=256. The LRU then misses on every lookup and steps get about 5x slower. Fixes testflows#15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15
Contributor License Agreement
For more information see https://github.com/testflows/TestFlows/blob/master/CONTRIBUTING.md.
I, the Contributor, have agreed to and signed the CLA.
Description of Changes
Remove the size limit on the
_compile_patterncache intestflows/_core/name.py. Fixes #15.Each step matches every live xfails/ffails pattern twice. Above 128 live patterns, the 256-entry LRU misses on every lookup and steps get about 5x slower. With
maxsize=None, the repro from #15 runs 2000 steps in 0.99 s instead of 4.8 s. Test results don't change, because the cache memoizes a pure function.