Skip to content

fix: focus and commit the tab rename field in settings - #4

Merged
thamaraiselvam merged 1 commit into
mainfrom
fix-tab-rename-focus
Oct 11, 2026
Merged

thamaraiselvam merged 1 commit into
mainfrom
fix-tab-rename-focus

Conversation

@thamaraiselvam

Copy link
Copy Markdown
Owner

Summary

  • Settings → Tabs: the rename field never got keyboard focus (same bug fixed for task rows in 31b0bc3), so typing went nowhere.
  • Focus the field on appear, commit on focus loss, Escape cancels, empty name keeps the old name, whole Rename button is clickable.
  • OpenSpec change fix-tab-rename-focus with a modified tab-management spec.

Test plan

  • swift build with full Xcode
  • Manually verified in the running app (by the author): focus, Enter, click-away, Escape, empty name

🤖 Generated with Claude Code

The rename field never received focus, so it looked like plain text and
swallowed typing. Focus it once it appears, commit on focus loss, cancel
on Escape, and make the whole Rename button clickable.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T06:43:50.246920Z bdfac06 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@thamaraiselvam
thamaraiselvam merged commit 0d0d757 into main Oct 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant