Repository navigation
Conversation
Since the multi-arch build was split (54426bf), the tag of the PHP patch version was computed without IS_RELEASE: the bake file then drops it and the first tag is the X.Y one. The X.Y tag was copied twice and no X.Y.Z-v5-* tag was published since 2025-12-10. Compute it with IS_RELEASE=1 and take the second tag, which is the patch version one.
packages.sury.org now publishes the fixed PHP packages for arm64: a vulnerable arm64 image fails the php2shell test again instead of only emitting a warning, and the docs no longer say that the arm64 images are not fixed. The php2shell backport keeps the version number of PHP 7.4, 8.0 and 8.1: tag their fixed images X.Y.Z-php2shell-v5-* in the legacy workflow, so that the existing X.Y.Z-v5-* tags stay unchanged.
mistraloz
changed the title
Readers of the first php2shell note were told that the arm64 images were not fixed: tell them that they are now, and to pull them again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #424, to merge once packages.sury.org has the php2shell fix for arm64 (deb.sury.org#145).
This PR fixes/implements :
Changes:
8.5.12-v5-cli& co. have not been published since 2025-12-10. Since 54426bf, the publish step builds the patch tag withoutIS_RELEASE=1, so the bake file drops it and theX.Ytag is copied twice. Fixed inworkflow.ymlandlegacy-v5.yml.X.Y.Z-php2shell-v5-*and the existing7.4.33-v5-*/8.0.30-v5-*tags stay untouched. One-off, for this fix only.Older patch tags (e.g.
8.5.0-v5-cli) stay as they are: they are immutable.Test plan (required)
docker buildx bake --printfor slim, fat and node targets:X.Y.Z-v5-*for 8.2+,X.Y.Z-php2shell-v5-*for 7.4 to 8.1,X.Y-v5-*unchanged.legacy-v5.ymlrun:8.5.12-v5-cliand7.4.33-php2shell-v5-cliexist on amd64 and arm64,7.4.33-v5-cliis unchanged.Checklist
I followed the guidelines in CONTRIBUTING guide
I have squashed any insignificant commits
This change has comments for package types, values, functions, and non-obvious lines of code
Fixed PHP packages available on packages.sury.org for Ubuntu noble: