Skip to content

Vouch Request: bharathkumar39293 #3216

Closed as not planned
Closed as not planned
Vouch Request: bharathkumar39293#3216

Description

@bharathkumar39293
bharathkumar39293
opened on Mar 14, 2026

Why do you want to contribute?

I'm interested in improving the robustness of the Trigger.dev SDK. I've been working on defining strict Zod schemas for the API client to replace placeholder z.any() calls, specifically for the listRunEvents endpoint. This improves type safety and prevents runtime validation errors across the platform, including the MCP server

Prior contributions or relevant experience

I have previously contributed to this repository! My PR #2874 ('Fix/sdk stream root fallback') was merged in January 2026. I am now following up with more SDK improvements in PR #3215, but it was auto-closed because I'm not on the vouched list yet. You can see my history of contributions on this account and my previous merged work here: #2874

Activity

  1. ericallam commented on Mar 14, 2026

    @ericallam
    ericallam
    on Mar 14, 2026
    Member

    @bharathkumar39293 I'll add you to the vouch list! Just a heads up, we may stay close opened PRs if we decide that the cost of integrating the PR outways the benefits. There are some things you can do to help improve the chance of your PR getting accepted:

    • Do some cost/benefit analysis yourself first. If the change is risky to ship, consider what the benefit would be to users. Including this analysis in the PR would go a long way.
    • Always open your PRs in draft status first, and address any CodeRabbit code review comments first.
    • Don't mark the PR "Ready to Review" untill all CodeRabbit code review comments have been resolved (some you will be able to just mark as resolved, but ideally with a comment).
    • Don't mark the PR "Ready to Review" until all CI checks pass

  2. matt-aitken commented on Oct 7, 2026

    @matt-aitken
    matt-aitken
    on Oct 7, 2026
    Member

    We have a new Vouch policy, please see the discussion here: #5010

  3. matt-aitken
    closed this as not plannedon Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions