You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Oh nice, I remember running into a similar situation when I was contributing to a library with a complex event-driven architecture like trigger.dev. One thing that stood out from your PR is the way you're handling hooks, I've found that explicitly passing dependencies in an array can avoid some subtle bugs.
Here's a pattern I've used that might help:
useEffect(()=>{// Your logic heresomeAsyncFunction().then(setData);},[dependency1,dependency2]);// Always include dependencies here
If you're not careful with your deps, React can get weird with stale closures.
Activity
gameroman commentedon Jun 29, 2026
Hi @matt-aitken sorry for the ping, anything I can do here to get accepted?
gameroman commentedon Jul 24, 2026
@ericallam
rehan243 commentedon Jul 26, 2026
Oh nice, I remember running into a similar situation when I was contributing to a library with a complex event-driven architecture like trigger.dev. One thing that stood out from your PR is the way you're handling hooks, I've found that explicitly passing dependencies in an array can avoid some subtle bugs.
Here's a pattern I've used that might help:
If you're not careful with your deps, React can get weird with stale closures.
matt-aitken commentedon Oct 7, 2026
We have a new Vouch policy, please see the discussion here: #5010