You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Filing this Vouch Request per the repo's contributor-vouching process (unvouched PRs are auto-closed). Please apply the vouch-request label if needed.
Why do you want to contribute?
Hi! I use Trigger.dev and, while reading through the realtime client, I found a bug I'd like to fix: booleanHelpersFromRunStatus in packages/core/src/v3/apiClient/runStream.ts computes isCompleted as successful || failed, omitting the terminal CANCELED status. So a canceled run on the realtime path (runs.subscribeToRun() / useRealtimeRun()) reports isCompleted: false, while REST (runs.retrieve()) and the docs treat it as completed — and react-hooksuseRun relies on isCompleted to stop refetching, so canceled runs never settle on the realtime path. I have a focused fix ready: a per-status completedStatuses set, a load-bearing regression test driving a CANCELED run through RunSubscription, and a changeset. (I also spotted a separate, pre-existing REST isFailed inconsistency for canceled runs, which I'd file as its own issue rather than mix in.)
Prior contributions or relevant experience
I keep PRs small, tested, and conventional. Some recent open-source fixes:
Activity
matt-aitken commentedon Oct 7, 2026
We have a new Vouch policy, please see the discussion here: #5010