Skip to content

Vouch request: fix for #4264 #4410

Closed as not planned
Closed as not planned

Description

@guillaume-flambard

Why do you want to contribute?

I'd like to fix #4264: envvars.update() throws ReferenceError: name is not defined when called outside a task context (management API / deploy scripts).

I verified the root cause in packages/trigger-sdk/src/v3/envvars.ts — the non-task branch assigns $name = name!, but the third positional parameter is named nameOrRequestOptions, so name is not in scope. create / del / retrieve / list are unaffected. A previous PR for the same issue (#4265) was auto-closed because the author wasn't vouched.

The fix is ready locally: use nameOrRequestOptions (with a typeof === "string" guard), plus a patch changeset for @trigger.dev/sdk. Happy to open a draft PR once vouched.

Prior contributions or relevant experience

Recent OSS PRs:

GitHub: https://github.com/guillaume-flambard

Activity

  1. matt-aitken commented on Oct 7, 2026

    @matt-aitken
    Member

    We have a new Vouch policy, please see the discussion here: #5010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions