Repository navigation
Vouch Request: blockgroot — fix for #2622 (Zod v4 instanceof check in tools.ts) #4414
Closed as not planned
Description
Why do you want to contribute?
I'd like to fix #2622 — @trigger.dev/core's convertToolParametersToSchema in packages/core/src/v3/types/tools.ts uses toolParameters instanceof z.ZodSchema to detect a Zod schema, which breaks for consumers on Zod v4 (Zod v4 doesn't export ZodSchema the same way, causing build failures in downstream apps like Next.js). The fix is straightforward: the codebase already has the correct version-agnostic pattern in schemas.ts (isSchemaZodEsque, which duck-types _def/parse/parseAsync/safeParse instead of using instanceof) — I'd reuse that helper in tools.ts instead. I'll add a regression test and a changeset.
Prior contributions or relevant experience
No response
Activity
blockgroot commentedon Jul 29, 2026
Update: three fixes are now implemented and pushed to my fork, each with a regression test that fails before the fix and passes after. Each is scoped to a single issue per the one-issue-per-PR rule, ready to open as a PR the moment I'm vouched.
blockgroot/trigger.dev@fix/tool-schema-zod-v4-detection(compare)perf(webapp): lack of pagination in GET /api/v1/runs/:runId/events endpoint risks out-of-memory crashes#3730 — unbounded run-events fetch:blockgroot/trigger.dev@fix/paginate-run-events(compare)perf(supervisor): sequential inspect loop in DockerResourceMonitor blocks task scheduling thread#3727 — sequential Docker inspect loop in the supervisor:blockgroot/trigger.dev@fix/parallel-docker-inspect(compare)Happy to open PRs for any/all of these once vouched — let me know if you'd like me to start with a particular one.
matt-aitken commentedon Oct 7, 2026
We have a new Vouch policy, please see the discussion here: #5010