Repository navigation
feat(badges): add name property to badge models and mock - #1155
Merged
Merged
Conversation
msrouchou
reviewed
Oct 8, 2026
Member
|
Thanks for the PR. A few points:
|
* GitLab badges support an optional name field. Expose it on Badge, BadgeCreate and BadgeUpdate so callers can set and read it. * Mock: store the name on Badge. Set it on create and update in the project and group badge clients. * Mock: add a BadgeCollection.Add(name, linkUrl, imageUrl) overload. Keep the old Add(linkUrl, imageUrl) overload so existing callers still compile. * Tests: cover name on create and update for project and group badges, in both the integration tests and the mock tests.
jasonwoods-7
force-pushed
the
feat/badge-name
branch
from
October 9, 2026 13:49
9e50c4f to
0c64561
Compare
Contributor
Author
|
It looks like Claude fixed everything except point 3 in your review. I asked about that and it said
Would you like that added? |
Member
nah it is fine, merging, thank you for the contribution. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
namefield. Expose it onBadge,BadgeCreateandBadgeUpdateso callers can set and read it.Badge. Set it on create and update in the project and group badge clients.BadgeCollection.Add(name, linkUrl, imageUrl)overload. Keep the oldAdd(linkUrl, imageUrl)overload so existing callers still compile.