Repository navigation
DX-3075: publish the CLI as upstash, so npx upstash runs setup - #28
Merged
Merged
Conversation
The CLI will also be published as the unscoped `upstash` package, from the same build with the same version, so `npx upstash` works. Under that name a bare `upstash` in a terminal runs `upstash setup`; with arguments it is the full CLI. Outside a terminal a bare `upstash` keeps printing the help, so an agent or script never rewrites agent configs by accident. @upstash/cli is unchanged. A second publish rather than a wrapper that depends on @upstash/cli: both packages would declare an `upstash` bin, and npm can link the dependency's bin instead of the wrapper's, which skips the setup default. The release workflow change that publishes the second package is in the PR description, to be added by someone with workflow permissions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LWUubWwYWp1dZTK1S9Ek95
`upstash` is now the primary package name. The release workflow publishes it, then the same build again as @upstash/cli, so existing installs keep getting releases and the old name can be deprecated later with one command. With both names running the same code, the name check is gone: a bare `upstash` in a terminal runs `upstash setup` under either name, and outside a terminal it still prints the help. The telemetry header keeps reporting @upstash/cli so the analytics series stays continuous. The release workflow change ships separately (it needs workflow permissions). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LWUubWwYWp1dZTK1S9Ek95
CahidArda
changed the title
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The dual-publish workflow cannot safely recover when only the second publication fails.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Publishes the CLI under upstash while preserving @upstash/cli, and makes bare interactive invocations run setup.
Changes:
- Adds terminal-aware default setup behavior and tests.
- Renames the primary npm package and updates documentation.
- Extends releases to publish both package aliases.
| File | Description |
|---|---|
src/cli.ts |
Applies the default command before parsing. |
src/default-command.ts |
Selects setup for bare interactive invocations. |
tests/unit/default-command.test.ts |
Tests default-command behavior. |
README.md |
Documents the new package and invocation. |
package.json |
Renames the npm package. |
package-lock.json |
Synchronizes package metadata. |
.github/workflows/release.yml |
Publishes both npm package aliases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| - name: Publish @upstash/cli release candidate | ||
| if: github.event.release.prerelease | ||
| run: npm publish --access public --tag=canary --provenance |
alitariksahin
approved these changes
Oct 5, 2026
This was referenced Oct 6, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.