[bbadour]

Include an empty argument and all subsequent arguments.

What type of PR is this?

• bug

What this PR does / why we need it:

Sometimes command line arguments are empty strings.

i.e.

command subcommand '' 'anotherarg'

Which issue(s) this PR fixes:

Fixes #2234

Release Notes

Allow empty command line arguments. i.e. "", '' etc.

[dearchap]

Please remove this change from this PR.

[dearchap]

Please remove this from PR

[dearchap]

@bbadour try to focus on one issue per PR.

[Juneezee]

Thanks for the fix, and sorry this sat so long.

This bug is already fixed on main. #2296 fixed it (released in v3.8.0) when it was reported again as #2292, and #2328 added a regression test with the repro from #2234:

cli/command_parse.go

Lines 91 to 95 in e03df0f

	firstArg := strings.TrimSpace(rargs[0])
	if len(firstArg) == 0 {
	posArgs = append(posArgs, rargs[0])
	continue
	}

cli/command_test.go

Lines 7523 to 7568 in e03df0f

	// Regression for #2234: an empty positional arg following a flag used to be
	// dropped along with every arg after it.
	func TestEmptyPositionalArgsAfterFlag(t *testing.T) {
	testCases := []struct {
	Name string
	Args []string
	ExpectedArgs []string
	ExpectedFlag string
	}{
	{
	Name: "empty arg after equals-form flag",
	Args: []string{"app", "-f=something", "", "arg2", "arg3"},
	ExpectedArgs: []string{"", "arg2", "arg3"},
	ExpectedFlag: "something",
	},
	{
	Name: "empty arg after space-form flag",
	Args: []string{"app", "-f", "something", "", "arg2"},
	ExpectedArgs: []string{"", "arg2"},
	ExpectedFlag: "something",
	},
	}
	for _, tc := range testCases {
	t.Run(tc.Name, func(t *testing.T) {
	var args []string
	var flagVal string
	cmd := &Command{
	Flags: []Flag{
	&StringFlag{Name: "f"},
	},
	Action: func(_ context.Context, cmd *Command) error {
	args = cmd.Args().Slice()
	flagVal = cmd.String("f")
	return nil
	},
	}
	err := cmd.Run(buildTestContext(t), tc.Args)
	assert.NoError(t, err)
	assert.Equal(t, tc.ExpectedArgs, args)
	assert.Equal(t, tc.ExpectedFlag, flagVal)
	})
	}
	}

The fix on main keeps the empty arg and keeps parsing flags after it. This PR stops parsing flags at the empty arg, so with app "" -f=x arg2, -f=x ends up as a positional arg instead of setting f.

The flag_ext.go change is an earlier version of #2227, so we can review it there.

Closing as superseded. Thanks again!