refactor(cli): replace clap with usage-rs - #694
Closed
fengmk2 wants to merge 2 commits into
Closed
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
fspy benchmarklinuxmacoswindows |
Co-authored-by: GPT-5 Codex <codex@openai.com>
fengmk2
force-pushed
the
refactor/usage-rs-cli-parser
branch
from
August 23, 2026 07:32
95765ec to
f216f9a
Compare
Member
Author
|
Closing this supporting experiment for now. The Vite+ evaluation found little difference in the final NAPI binary size. Replacing clap requires a major refactor, so we will not consider this migration now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Vite+ PR #2534 must remove
clapfrom its NAPI binary. Vite Task exports parser types to Vite+. Thus, its production crates must also removeclap.This change replaces the Vite Task
clapparsers withusage-rs. It pins an exact reviewed revision from the experiment fork. One typed grammar now supplies parsing, help, diagnostics, and completion data.The change keeps task argument forwarding, the
vprview, package filters, cache flags, log modes, and the internaltoolcommand. Completion includes command options, value choices, task names, package names, and package filters.Direct unit tests cover strict errors, help, short options,
--, completion candidates, and completion scripts. Existing end-to-end tests cover task forwarding and cache commands.The production dependency graph has no
clappath.libtest-mimicstill suppliesclapto test code. This PR increases the minimum Rust version from 1.89 to 1.91.