Repository navigation
fix(hooks): skip bash syntax check on Windows - #484
Open
Firefly0619sec wants to merge 1 commit into
Open
Firefly0619sec wants to merge 1 commit into
Firefly0619sec wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
validate_hook_commandalways runsbash -n -c <command>:On Windows there is no
bashon the default PATH (unless Git Bash/WSL is installed), so the command fails withFailed to validate command: ... program not foundand the hooks editor cannot validate anything.Change
On Windows, skip the syntax check and return
valid: truewith a short message, instead of erroring out. The hook is still executed by whatever shell the user configured; this only affects the optional syntax pre-check.Notes
powershell -NoProfile -Command "[scriptblock]::Create($cmd)", but hooks are often bash syntax, so skipping is the safer default.