Repository navigation
fix(security): narrow fs and assetProtocol scopes to $HOME - #485
Open
Firefly0619sec wants to merge 1 commit into
Open
Firefly0619sec wants to merge 1 commit into
Firefly0619sec wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The default capability set is broader than what the GUI actually needs:
capabilities/default.jsongrantsfs:read-allandfs:write-all— all filesystem paths, not just the ones the user opens;tauri.conf.jsonsetsassetProtocol.scopeto**— the asset protocol can read any path on disk.The app already has
fs:scope-home-recursiveandfs:scope-app-recursive, plus an explicit dialog picker, so the "all paths" grants are redundant for normal use.Change
fs:read-all/fs:write-all(keep the concretefs:allow-*permissions and the home/app scopes);assetProtocol.scopefrom**to$HOME/**.Impact
$HOMEkeeps working;$HOME(e.g.D:\projects) now require the user to pick them via the dialog, or the scope to be extended at runtime — which is the intended least-privilege behavior;Related
This complements #483 (web server no longer binds
0.0.0.0by default): together they remove the "unauthenticated LAN access + full-filesystem read/write" combination.