Repository navigation
chore: share one version sync script across plugins - #844
Merged
Merged
Conversation
The five bin/sync-package-version.sh copies differed only in the plugin file name and version constant, which both follow from the plugin folder name. Each plugin's `npm run version` now runs scripts/sync-plugin-version.sh, which works them out.
josephfusco
added
the
[Type] Task
josephfusco
added
the
[Area] Infrastructure
josephfusco
added
[Type] Task
|
Contributor
📦 Plugin Artifacts Ready!Download from GitHub Actions run Available plugins:
See the "Artifacts" section at the bottom of the Actions run page |
Contributor
🔍 WordPress Plugin Check Report
📊 Report
❌ Errors (1)📁 readme.txt (1 error)
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the five
bin/sync-package-version.shcopies with onescripts/sync-plugin-version.sh.Why
The copies were identical except for two lines: the main plugin file name and the version constant (for example
hwp-previews.phpandHWP_PREVIEWS_VERSION). Both follow from the plugin folder name, the same convention every plugin already uses. The shared script works them out from the folder, so a new plugin needs no copy.How it's wired
"version"npm script now points to../../scripts/sync-plugin-version.sh. It runs from the plugin folder, the same as before. You can also pass a plugin folder as the first argument.npm run versionin the plugin folder, so it doesn't change.bin/was already left out of the plugin zips.Testing
package.jsonto 9.9.9 in two scratch copies, then ran the old per-plugin script on one and the new shared script on the other. The resultingcomposer.json,readme.txt, and main plugin file are byte-identical. Each main file has both the headerVersionand the constant bumped.npm run versionin hwp-previews runs the new script and leaves the files unchanged when the version hasn't changed.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with consolidating the per-plugin version scripts and checking that the result is identical.