Repository navigation
Preserve field metadata through physical CASE expressions - #125
Merged
Merged
Conversation
osipovartem
force-pushed
the
df55-physical-case-metadata
branch
from
October 9, 2026 15:06
82a027c to
54db65b
Compare
osipovartem
marked this pull request as ready for review
October 9, 2026 15:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port apache/datafusion#26158 to our pinned DF55 fork. Physical CASE preserves agreed Arrow field metadata, including nested CASE and casts. The planner retains the logical result field when physical lowering loses metadata context, and physical-expression protobuf round-trips that field. The common unmarked Column/Literal path is unchanged.
The matching logical CASE change was merged into
embucket-sync-df55.0.0via #126. This branch is rebased onto that base. The Rustice integration uses a separately pinned branch containing both changes.Validation
cargo +stable test -p datafusion-physical-expr --features proto --lib --quiet: 1,688 passed, 2 ignored on this branch.NOT, child rewrites, and protobuf encode/decode.metadata.sltSQLLogicTest passed on the rebased branch, including direct and projected CASE metadata checks.54db65b1cwith no blockers.Upstream: apache#26158