Repository navigation
Preserve logical CASE field metadata on DF55 base - #126
Merged
osipovartem merged 12 commits intoOct 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port the logical CASE field-metadata change from apache/datafusion#26145 onto
embucket-sync-df55.0.0. Matching result branches retain Arrow field metadata; incompatible branches conservatively clear it. The ordinary unmarked CASE fast path remains unchanged.The earlier fork PR #122 was merged into a CSV feature branch, not the DF55 base. This branch carries only the logical CASE commits onto the current base; it does not bring over that branch's CSV changes.
Validation
cargo +stable test -p datafusion-expr --lib --quiet: 255 passed.cargo +stable fmt --all --checkandgit diff --check: passed.cargo +stable test -p datafusion-optimizer --lib --quiet: 761 passed.cargo +stable test -p datafusion --test core_integration test_sql_case_field_metadata: passed.Integration
Merge this before physical CASE PR #125, then run the combined
metadata.sltregression there. Rustice is separately testing both changes on its pinned DataFusion branch.