Repository navigation
chore(TD-9488): migrate yarn→npm + nock coverage net - #168
Merged
Merged
Conversation
Groundwork before the EOL dependency upgrades (TD-9488): - Migrate package manager yarn -> npm: regenerate lockfile as package-lock.json, de-yarn all package.json scripts, husky pre-commit, and lint-staged. CI switched to npm ci / npm run build, setup-node@v4, Node 22. Add .npmrc legacy-peer-deps=true for bunyan-category's exact @types/bunyan@1.8.6 peer (to be removed when bunyan-category is replaced). - Add src/index.nock.test.ts: 38 nock-based tests covering the previously untested Apollo graphClient methods (create/update/delete entity, relationship, question, integration instances, etc.). Raises src/index.ts coverage 41.6% -> 64.6%. Safety net for the Apollo 2 -> 4 migration. Existing PollyJS tests left untouched. - Add planning + contract docs: DEPENDENCY-AUDIT.md (phased EOL plan), PUBLIC-API.md (frozen consumer contract + Apollo-4-risk behaviors), PUBLIC-API.baseline.d.ts (machine-diffable type snapshot at v2.1.2), excluded from tsc/eslint. npm audit drops 322 -> 35 from the fresh dedup'd install. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…interim - Remove the Jira assignee name and internal ship deadline from DEPENDENCY-AUDIT.md (this is a public repo; that metadata is permanent in history once merged and belongs on the ticket, not here). - Note that nock is pinned to ^11 as an interim because nock 14's types do not parse under TypeScript 3.8; it is bumped to ^14 in Phase 1a once TS 5.x lands. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tom-foley-j1
approved these changes
Oct 21, 2026
VDubber
added a commit
that referenced
this pull request
Oct 21, 2026
Keep the feature stack at 2.1.2 so merging #168-#171 to main does not trigger the version-gated auto-publish mid-stack. The 3.0.0 bump + npm publish happen in a dedicated release PR merged last, matching this repo's release-X.Y.Z convention (cf. #165 release-2.1.2, #161 release-2.0.1). CHANGELOG 3.0.0 notes and MIGRATING-v3.md remain in the feature PRs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tom-foley-j1
approved these changes
Oct 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TD-9488 — Groundwork before EOL dependency upgrades
Foundation PR. No runtime behavior change — sets up a clean package manager + a test safety net so the Apollo/graphql/node EOL upgrades (follow-up PRs) can be validated.
Package manager: yarn → npm
yarn.lockremoved,package-lock.jsongeneratedpackage.jsonscripts,.husky/pre-commit,lint-stagedbuild.yml):npm ci/npm run build,setup-node@v4, Node 22 (was EOL 18).npmrclegacy-peer-deps=true— bunyan-category pins exact@types/bunyan@1.8.6; removed once bunyan-category is replaced (Phase 1b)Test coverage net (nock)
src/index.nock.test.ts— 38 tests covering previously-untested ApollographClientmethods (entity/relationship/question CRUD, integration instances, endpoint routing)src/index.tscoverage 41.6% → 64.6%Planning + contract docs
DEPENDENCY-AUDIT.md— phased EOL remediation plan + live statusPUBLIC-API.md— frozen consumer contract + §6a Apollo-4-sensitive behaviorsPUBLIC-API.baseline.d.ts— machine-diffable type snapshot at v2.1.2 (diffafter each upgrade phase); excluded from tsc/eslintSecurity
npm audit: 322 → 35 vulns from the fresh dedup'd install (remaining high/critical handled viaoverridesin the next PR)Next PRs (TD-9488, by Nov 1)
.nvmrc,engines,js-yaml 3→4,overridesfor residual vulnsinflightchain (drop bunyan optional deps).d.ts🤖 Generated with Claude Code