Repository navigation
ci: fix Homebrew workflows (setup-homebrew@main, post_install_steps, tap trust) - #2112
Merged
sbryngelson merged 3 commits intoOct 26, 2026
Merged
Conversation
Homebrew renamed the default branch of Homebrew/actions from master to main, so @master no longer resolves and Homebrew Formula Test fails at job setup.
sbryngelson
requested review from
danieljvickers
and removed request for
a team
October 26, 2026 18:29
The new FormulaAudit/InstallSteps cop rejects post_install methods.
sbryngelson
had a problem deploying
to
homebrew
October 26, 2026 18:31 — with
GitHub Actions
Failure
|
Claude Code Review Head SHA: 9688739 Files changed:
Findings: No issues found. Checked the changed hunks in .github/workflows/deploy-tap.yml and .github/workflows/homebrew.yml. Both only change the |
brew now refuses to load formulae from untrusted taps. The audit in homebrew.yml was failing behind || true, and the audit in deploy-tap.yml has no fallback, so the next formula push to master would fail.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew renamed the default branch of
Homebrew/actionsfrommastertomain. Workflows that pin@masterno longer resolve, so Homebrew Formula Test fails at job setup before any step runs (run 40377630642, on the v5.7.1 tag push):Change
Homebrew/actions/setup-homebrew@masterbecomes@mainin the two workflows that use it:.github/workflows/homebrew.yml(Homebrew Formula Test).github/workflows/deploy-tap.yml(not yet triggered since the rename, but would fail the same way)mainkeeps the current behaviour of tracking Homebrew's latest action.setup-homebrew/action.ymlexists onmain.homebrew-release.ymldoes not use this action, which is why the v5.7.1 tap update succeeded.Second break uncovered:
FormulaAudit/InstallStepsWith the action resolving again,
brew stylefailed on a new cop:Homebrew now rejects
post_installmethods in every tap (Formula Cookbook); post-install work must be declared with thepost_install_stepsDSL. The formula's only post-install action was achmod 0755on thelibexec/mfcwrapper, which maps directly onto the supportedset_permissionsstep:Third break: untrusted taps
brewnow refuses to load a formula from an untrusted tap:In
homebrew.ymlthe audit ends in|| true, so this failed silently and the audit has not been running. Indeploy-tap.ymlthe audit has no fallback, so the push to master that merging this PR triggers (it changesmfc.rb) would have failed. Each temporary tap is now trusted right afterbrew tap-new:mflowcode/testtwice inhomebrew.yml,mfc/localindeploy-tap.yml. With this, the audit inhomebrew.ymlruns and reports no problems. The--strict --newaudit indeploy-tap.ymlruns only on master and is not exercised by this PR.