Skip to content

ci: fix Homebrew workflows (setup-homebrew@main, post_install_steps, tap trust) #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbryngelson merged 3 commits into from
Oct 26, 2026
Merged

ci: fix Homebrew workflows (setup-homebrew@main, post_install_steps, tap trust) #2112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9688739
ci: pin Homebrew/actions/setup-homebrew to main
sbryngelson Oct 26, 2026
a69ab4c
homebrew: use post_install_steps instead of post_install
sbryngelson Oct 26, 2026
cffbdae
ci: trust the temporary Homebrew taps before auditing
sbryngelson Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/deploy-tap.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,14 @@ jobs:
/usr/bin/sed -i '' "s@^ sha256 \".*\"@ sha256 \"${{ steps.meta.outputs.sha256 }}\"@" packaging/homebrew/mfc.rb

- name: Setup Homebrew
uses: Homebrew/actions/setup-homebrew@master
uses: Homebrew/actions/setup-homebrew@main

- name: Audit/style formula before pushing
run: |
brew style packaging/homebrew/mfc.rb
# Create temporary tap to audit the formula
brew tap-new mfc/local
brew trust mfc/local
cp packaging/homebrew/mfc.rb "$(brew --repository)/Library/Taps/mfc/homebrew-local/Formula/mfc.rb"
brew audit --online --strict --new --except=homepage mfc/local/mfc || brew audit --online mfc/local/mfc
brew untap mfc/local
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/homebrew.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
uses: actions/checkout@v5

- name: Set up Homebrew
uses: Homebrew/actions/setup-homebrew@master
uses: Homebrew/actions/setup-homebrew@main

- name: Validate formula syntax with brew style
run: |
Expand All @@ -41,6 +41,7 @@ jobs:

echo "Creating temporary local tap..."
brew tap-new mflowcode/test
brew trust mflowcode/test
cp packaging/homebrew/mfc.rb $(brew --repository)/Library/Taps/mflowcode/homebrew-test/Formula/mfc.rb

echo "Running brew audit (online checks)..."
Expand Down Expand Up @@ -143,6 +144,7 @@ jobs:
run: |
echo "Creating temporary local tap..."
brew tap-new mflowcode/test
brew trust mflowcode/test

echo "Copying formula to tap..."
cp packaging/homebrew/mfc.rb $(brew --repository)/Library/Taps/mflowcode/homebrew-test/Formula/mfc.rb
Expand Down
4 changes: 2 additions & 2 deletions packaging/homebrew/mfc.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,9 +279,9 @@ def _homebrew_is_buildable(self):
bin.write_exec_script libexec/"mfc"
end

def post_install
post_install_steps do
# Fix executable permissions for libexec wrapper
(libexec/"mfc").chmod 0755
set_permissions "mfc", "0755", base: :libexec
end

# Override to skip relocation checks for Python C extensions in venv
Expand Down
Loading