Repository navigation
Conversation
…ab header matches the route - Log row actions overlay the row (hover, focus, focused row) instead of reserving ~104px, so messages run out to the chips; the invisible no-trace placeholder is gone, row height kept. - The Cloudflare lab renders the route's title row (description, time range, Reload) through a shared titleRow; viewHref and ClickedView share one search transition (review note on #1827).
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Maple review🟢 Confidence 9/10 · safe to merge Log row actions move out of the row's flow and overlay the message tail, and the Cloudflare list's title row is extracted so the lab renders the route's header, time controls and Reload. The extractions preserve behavior; safe to merge.
What was checked
|
🍁 Maple PR previewNote Preview resources were removed when this pull request closed. Final commit |
Maple review🟢 Confidence 9/10 · safe to merge Log rows overlay their hover actions on the message instead of reserving a column, and the Cloudflare lab list now renders the route's extracted
Before merge
What was checked
|
|
Preview check (separate agent, app-pr-1829 with seeded logs): all 6 PASS. Messages run to ~8px from the chips (the #1826 blank band is gone). Hover shows Copy message / Copy link / Open trace / Open details clear of the chips; Open details opens the dialog and Open trace goes to its |
Maple review🟢 Confidence 9/10 · safe to merge Moves the logs row's hover actions into an overlay inside the message lane, and gives the Cloudflare lab the route's shared
Before merge
What was checked
|
|
Merged with 1 step from "Before merge" still open. If it is done, tick it on the review comment; if not, now is the time.
|
Design pass 7, stacked on #1828 (pass 6). Two independent agents checked it blind: one scored a rubric, the other hunted regressions and found none. Icons and data colours are untouched.
Judges
Changes
Logs: messages use the full row. The hover actions group reserved about 104px on every row, plus an invisible placeholder on rows without a trace link, which left a blank band right of the chips (also seen on the #1826 preview). The actions now overlay the row, shown on hover, keyboard focus or the stream's focused row. Messages run out to the chips, and rows can show a second chip. Row height is unchanged. A new scene test pins that a row with a trace links to it and a row without one keeps "Open details".
Cloudflare: the real route already had its description, time range and Reload. The lab drew only the title, so it now renders the same shared
titleRow.viewHrefandClickedViewshare one search transition, so the tab link and the click cannot drift (review note F1 on #1827).Verification
bun run --cwd apps/web typecheckpasses, andoxlintis clean.🤖 Generated with Claude Code