Repository navigation
test(manifest): key Maven repo-inheritance roots by project id - #1594
Merged
Jeppe Fredsgaard Blaabjerg (jfblaa) merged 1 commit intoOct 9, 2026
Merged
Jeppe Fredsgaard Blaabjerg (jfblaa) merged 1 commit into
Jeppe Fredsgaard Blaabjerg (jfblaa) merged 1 commit into
Conversation
Project records are keyed group:artifact:version since each JVM build project got its own id, so matching roots by bare module name found none and the smoke test failed on every Maven version.
Jeppe Fredsgaard Blaabjerg (jfblaa)
enabled auto-merge (squash)
October 8, 2026 15:27
Oskar Haarklou Veileborg (BarrensZeppelin)
approved these changes
Oct 9, 2026
Jeppe Fredsgaard Blaabjerg (jfblaa)
deleted the
jfblaa/fix-maven-repo-inheritance-assertion
branch
October 9, 2026 08:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Claude Code:claude-opus-5-5
The Maven
repo-inheritancecompat smoke test failed on every Maven version: it matchedrootrecords by bare module name (liba), but since #1591 project records are keyedgroup:artifact:version(demo:liba:1.0). The extension's output was already correct (widget resolved via liba's repository, theliba -> widgetedge present in libb's root, jar materialized); only the assertion was stale.Verified with
run-compat.sh all: every Gradle and Maven row passes, includingrepo-inheritanceon Maven 3.2.5 through 4.0.0-rc-6. This change doesn't touch sbt, and all sbt rows pass when run directly.🤖 Generated with Claude Code
Note
Low Risk
Test-only assertion updates with no runtime or extension code changes.
Overview
Fixes the Maven repo-inheritance compat smoke test so it keys
rootrecords the same way as the extension after #1591: full Maven coordinates (demo:liba:1.0,demo:libb:1.0) instead of bare module names (liba,libb).Adds a
LIBBconstant alongside existingLIBA/WIDGETand uses those IDs in the root lookup loop and thelibb→liba→widgetedge assertion. No production or extension behavior changes—only the test expectations were stale while the emitted records were already correct.Reviewed by Cursor Bugbot for commit 23e6846. Configure here.