Skip to content

Repository navigation

test(manifest): key Maven repo-inheritance roots by project id #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jeppe Fredsgaard Blaabjerg (jfblaa) merged 1 commit into from
Oct 9, 2026
Merged

test(manifest): key Maven repo-inheritance roots by project id #1594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/commands/manifest/scripts/test/maven-compat/smoke-test-repo-inheritance.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ for r in rows:

WIDGET = 'demo.scoped:widget:jar:1.0'
LIBA = 'demo:liba:1.0'
LIBB = 'demo:libb:1.0'
errors = []

if failures:
Expand All @@ -60,7 +61,7 @@ if failures:
def roots_for(project_key):
return {rid for rid, key in roots.items() if key == project_key}

for project_key in ('liba', 'libb'):
for project_key in (LIBA, LIBB):
rids = roots_for(project_key)
if not rids:
errors.append(f"no root record for module {project_key!r}")
Expand All @@ -69,7 +70,7 @@ for project_key in ('liba', 'libb'):
errors.append(f"{WIDGET} missing from {project_key}'s graph")

# The point of the fixture: libb reaches widget only through the reactor module liba.
if not any(rid in roots_for('libb') and p == LIBA and c == WIDGET for rid, p, c in edges):
if not any(rid in roots_for(LIBB) and p == LIBA and c == WIDGET for rid, p, c in edges):
errors.append(f"no {LIBA} -> {WIDGET} edge in libb's root")

jars = [p for p in files.get(WIDGET, ()) if p.endswith('.jar')]
Expand Down
Loading