Repository navigation
fix(plugins): offer Parquet in Export until the manifest lists it - #3508
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#3503 builds the Export dialog's install offers from
exportFormatIdsin v3.json, butscripts/release/registry.pynever writes that field. Once 0.82.0 ships, a user without the Parquet plugin gets no Install Parquet… in the format menu, which the docs still describe.Change
registry.pychange takes over with no duplicate.Verified
ExportFormatCatalogTests:parquetOfferedWithoutManifestFormatsfails on main and passes here.installableComesFromTheManifestpinned the empty offer list on purpose and is replaced by the two new cases.Not in this PR
registry.pywritingexportFormatIdsfromTableProProvidesExportFormatIds; the hand Parquet entry goes with it.exportFormatIdsin TableProApp/docs (paired PR).