Repository navigation
Conversation
Scale-bound interactions with explicit values scanned every value on each pointer event: `indexOf` searched the array of value keys, and `valueAt` measured the distance to every position. A brushX over 120,000 hourly values spent about 12 ms per mouse move in these scans, enough to make dragging stutter. Record each value's index in the map that already checks values for uniqueness, and find the nearest position by binary search, which `assertMonotonePositions` already makes valid. Ties still resolve to the lower index, as with the linear search. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: d73c50c The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe interaction axis now maps explicit values to indexes and uses binary search to select the nearest mapped position. Tests cover forward and reversed mappings, ties, and present or absent values. ChangesInteraction axis lookups
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~15 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to No issue requiring a fix before merge is identified for the interaction-axis lookup change. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Scale-bound interactions with explicit values scanned every value on each pointer event:
indexOfsearched the array of value keys, andvalueAtmeasured the distance to every position. A brushX over 120,000 hourly values spent about 12 ms per mouse move in these scans, enough to make dragging stutter.Record each value's index in the map that already checks values for uniqueness, and find the nearest position by binary search, which
assertMonotonePositionsalready makes valid. Ties still resolve to the lower index, as with the linear search.Summary by CodeRabbit