Repository navigation
chore(octane-table): Upgrade to octane 0.12 and octane-store 0.13 - #6627
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 72b00f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (40)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Octane table package and examples update their Octane dependencies. Table components and the guide example now use context components with ChangesOctane compatibility
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~12 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The context migration and click-update timing match the resolved Octane implementation, and the example tooling dependency is declared. No concrete compatibility or installation issue remains evident. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description explains the code, dependency, documentation, test, and workspace changes. However, it does not use the required template sections and does not complete the checklist for contributing … | Update the description to include the required Changes, Checklist, and Release Impact sections. Mark each checklist item as complete or explain why it does not apply. Confirm whether tests were run or are not applicable, confirm contributin… |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly summarizes the primary change: upgrading the Octane table adapter to Octane 0.12 and octane-store 0.13. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Description check
Explanation
The description explains the code, dependency, documentation, test, and workspace changes. However, it does not use the required template sections and does not complete the checklist for contributing guidance, test execution or applicability, and AI-assisted code review. It also does not explicitly select the release-impact option.
Resolution
Update the description to include the required Changes, Checklist, and Release Impact sections. Mark each checklist item as complete or explain why it does not apply. Confirm whether tests were run or are not applicable, confirm contributing-guide compliance, confirm understanding of AI-assisted code, and select the appropriate release-impact option.
- Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
- Commit to this branch
- Create a new PR
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
View your CI Pipeline Execution ↗ for commit 72b00f0
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version Preview1 package(s) bumped directly, 0 bumped as dependents. 🟨 Minor bumps
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
1 participant
octanegoes from0.1.21to>=0.12.0. It's open-ended because octane ships a new minor every few days.@tanstack/octane-storegoes to^0.13.0.AppTable,AppCellandAppHeaderincreateTableHook.tsrxrender their contexts directly (<TableContext value>), since octane 0.12 removedContext.Provider. Thetable-contextdoc example is updated to match.@tsrx/oxc@0.20.0is a new dev dependency of the adapter and the octane examples. Octane 0.12 made it an optional peer of the compiler..click(). Octane 0.12 commits a click's updates in the microtask after the event, as React does, so asserting synchronously inside the event no longer holds. A plainuseStatecounter shows the same timing.PaginationStateimport in thecomposable-tablesexample that failedtest:types.pnpm-workspace.yamlexemptsoctane@0.12.1and@tanstack/octane-store@0.13.0from the 24-hour release-age gate. Both were published today.Notes
The changeset is
minorbecause the peer range narrows on 0.x octane.🤖 Generated with Claude Code
Summary by CodeRabbit
Compatibility
Documentation
Bug Fixes