Repository navigation
chore: refresh lockfile and fix Dependabot config path (DS-3444) - #83
Merged
Merged
Conversation
ikarachristos
added this pull request to stack #84
October 12, 2026 18:45
nikosd23
previously approved these changes
Oct 13, 2026
nikosd23
force-pushed
the
chore/DS-3444-lockfile-refresh
branch
from
October 13, 2026 06:16
4ece857 to
684521e
Compare
…(DS-3444) npm update within the existing semver ranges clears the dev alerts whose fixes were already allowed. amqplib stays on 0.10.x in the lockfile; its >=0.10.0 range would otherwise move CI to amqplib 2.x. GitHub only reads .github/dependabot.yml, so version updates never ran. Add the required schedule and group dev-dependency updates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nikosd23
force-pushed
the
chore/DS-3444-lockfile-refresh
branch
from
October 13, 2026 06:19
684521e to
d847774
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Step 2 of DS-3442. Stacked on #82: merge that first, then retarget this to
master.npm updatewithin the existing ranges. Most of the Dependabot alerts were old transitive versions whose fixes our ranges already allowed: js-yaml, brace-expansion, minimatch, picomatch, browserslist and @babel/core. Onlypackage-lock.jsonchanges, so nothing reaches consumers.>=0.10.0range would letnpm updatemove CI to amqplib 2.2.0. I kept the lockfile on 0.10.9 so this PR doesn't change what the tests run against. Whether to tighten the range is a separate decision..github/dependabot.yml, so version updates never ran. It also had noschedule, which version updates require. It now runs monthly, with dev-dependency updates grouped into one PR.Together with #82, this clears 20 of the 23 open alerts. The last 3 (serialize-javascript via mocha, uuid via nyc) need mocha 12 and nyc 18, which come in the next PR. Once that lands, #56 and #63 are stale and can be closed.
Testing
Lint and the full suite on RabbitMQ 3.13.7, run twice: 102 passing both times, the same as master.
🤖 Generated with Claude Code