Repository navigation
fix: preserve field metadata for simple CASE branches - #26145
Draft
osipovartem wants to merge 19 commits into
Draft
osipovartem wants to merge 19 commits into
osipovartem wants to merge 19 commits into
Conversation
osipovartem
marked this pull request as ready for review
October 8, 2026 22:24
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26145 +/- ##
==========================================
- Coverage 82.77% 82.76% -0.02%
==========================================
Files 1148 1148
Lines 451075 451632 +557
Branches 451075 451632 +557
==========================================
+ Hits 373397 373810 +413
- Misses 54930 54976 +46
- Partials 22748 22846 +98 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
osipovartem
marked this pull request as draft
October 8, 2026 23:00
osipovartem
marked this pull request as ready for review
October 9, 2026 08:58
osipovartem
marked this pull request as draft
October 9, 2026 12:37
(cherry picked from commit 816119e839317cca1b31ef02ad0e8e302e0c60d0)
(cherry picked from commit 185ae25)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Part of #24860. This is logical schema propagation for CASE, complementary to #24865.
What changes?
to_fieldcontract. Exact delegation is limited to expression depth 8 to bound repeated field inference. Deeper function branches and unsupported branch forms conservatively leave CASE metadata empty.CASEexpressions drop field metadata, silently stripping Arrow extension types and breaking metadata-aware UDFs #24860.Validation
datafusion-expranddatafusion-optimizersuites: 283 + 934 tests passed. Focused CASE tests, formatting, anddatafusion-exprtest-target Clippy also pass.core_integrationrun passed andcargo fmt --all --checkpassed.74ac5de5bat 74.06% patch coverage. Additional branch-focused tests were added incc221b5fd,d03385576, and3a8631b7f; a report for the current head is still pending. Some old partials are defensive errors and Rust?branches in tests. No coverage percentage is claimed for the current head yet.