Repository navigation
Conversation
the path sorting indentation requires child paths to follow right after their parent. But this isn't the case when simply sorting by String. added test note: Moved RandomlyFails annotation from test class to test methods, otherwise the testcase would not run.
mbien
added
Editor
ci:dev-build
Member
Author
|
usually we would revert changes if they don't work as expected. but this is probably small enough to fix during RC. ("famous last words") |
matthiasblaesing
approved these changes
Oct 18, 2026
matthiasblaesing
left a comment
matthiasblaesing
left a comment
Contributor
There was a problem hiding this comment.
Only eyeballed this, but the approach looks sane to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the path sorting indentation requires child paths to follow right after their parent. But this isn't the case when simply sorting by String.
I actually had that feeling that this wouldn't work while looking at the PR #9602 (comment), but I couldn't come up with an example at that time. PR was also merged without full review.
added test
note:
Moved
@RandomlyFailsannotation from test class to test methods, otherwise the new testcase would be running.fixes #9727
targets delivery