Skip to content

chore(gates): drop the daemon entry's over-ceiling approval now main carries it - #3653

Merged
thymikee merged 1 commit into
mainfrom
chore/drop-stale-daemon-entry-approval
Oct 15, 2026
Merged

thymikee merged 1 commit into
mainfrom
chore/drop-stale-daemon-entry-approval

Conversation

@thymikee

@thymikee thymikee commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

What

#3633 added an APPROVED_OVER_CEILING row for packages/daemon/src/index.ts. That row only covers a PR that introduces the entry. Now that main carries the entry, every branch cut from main fails eager-closure-budgets › no APPROVED_OVER_CEILING row is stale in the Coverage job; seen on #3638, #3644, #3646 and #3647.

This PR removes the row. Main itself stays green, because the stale check is skipped when the merge-base equals the head. That is also why #3633's own CI passed. The same thing happened to the maestro row after #3623.

Validation

pnpm exec vitest run scripts/__tests__/eager-closure-budgets.test.ts: 1022 passed on this branch. pnpm format: clean.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

…carries it

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Turn on auto-fix | Re-trigger cubic

@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 5.25 MB 5.25 MB 0 B
Package (unpacked) 5.25 MB 5.25 MB 0 B
Package (download) 1.58 MB 1.58 MB -4 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.2 ms 28.4 ms +1.2 ms
CLI --help 79.7 ms 82.1 ms +2.4 ms

@thymikee
thymikee merged commit eecb2b0 into main Oct 15, 2026
19 checks passed
@thymikee
thymikee deleted the chore/drop-stale-daemon-entry-approval branch October 15, 2026 12:20
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-15 12:31 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant